-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CI #583
Update CI #583
Conversation
molpopgen
commented
Nov 26, 2024
- bump ubuntu image and python
- Remove version pins from requirements files
- Add requirements_CI.txt
- update remaining work flow files
- remove global locked file
- Add pinned requirements files
- use pinned requirements files in CI
73b8340
to
5c676a1
Compare
@grahamgower -- This is all working other than codecov. The one test that needed updating was pretty straightforward as there was already a pytest warning filter in place. I just made the filter much stricter. I think I should also squash this down to 1 commit before merging? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. It would be good to squash this at least a little, yeah. Feel free to merge when you're satisfied.
@molpopgen, If you rebase, then the codecov upload should now work. Do we also need to bump the |
I'll look into this. I seem to recall that github has opened an issue on this repo for one or more of our automated things. |
793ae12
to
b927069
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #583 +/- ##
=======================================
Coverage 99.81% 99.81%
=======================================
Files 5 5
Lines 1600 1600
=======================================
Hits 1597 1597
Misses 3 3 ☔ View full report in Codecov by Sentry. |
@grahamgower -- I squashed all previous commits and separately updated mergify. As for |
@grahamgower -- I was hoping to have some way to actually test mergify but I have no idea how it works. I'm trying to find some kind of |
I think it's one of those things that is only acted upon after it's committed in the repository. |