Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump codecov action #584

Merged
merged 2 commits into from
Nov 26, 2024
Merged

bump codecov action #584

merged 2 commits into from
Nov 26, 2024

Conversation

molpopgen
Copy link
Collaborator

No description provided.

@molpopgen
Copy link
Collaborator Author

@grahamgower -- bumping the action to v5 didn't do the trick. It seems that some kind of authentication needs to happen. I don't think I have the ability to do that.

@grahamgower
Copy link
Member

For open source projects, Codecov has an exemption to requiring a token. But then we go into a queue for uploads that is shared with all the other open source projects, and it seems that items are often dropped from the queue. I'll look into what is required for getting a token.

@grahamgower
Copy link
Member

After adding the 'token:' line in the workflow file, the codecov upload just failed due to auth. Now I've added the token in the repository secrets and I'll rerun the failed tests...

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.81%. Comparing base (b579855) to head (eaac46e).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #584   +/-   ##
=======================================
  Coverage   99.81%   99.81%           
=======================================
  Files           5        5           
  Lines        1600     1600           
=======================================
  Hits         1597     1597           
  Misses          3        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@grahamgower grahamgower merged commit a296850 into main Nov 26, 2024
15 checks passed
@grahamgower
Copy link
Member

@grahamgower -- bumping the action to v5 didn't do the trick. It seems that some kind of authentication needs to happen. I don't think I have the ability to do that.

@molpopgen, you are in the demes-maintainers github group which is an admin for demes-python repo. Codecov inherits its admin settings from github, so you should also have the ability to poke anything on the codecov side (this is a bit opaque at first, but just log in to codecov and your repos/organisations will show up).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants