Skip to content

Commit

Permalink
[Integration][AWS] - RFC3339 format for organization account timestam…
Browse files Browse the repository at this point in the history
…ps (#1106)

# Description

What - Bug | Date-Time Format Discrepancies in Ports AWS Integration

Why -DateTime format from AWS for Account Organisation is not RFC 3339
compatible

How - 
Replace space delimiter with 'T' in JoinedTimestamp mapping to comply
with RFC3339 timestamp format specification

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)

<h4> All tests should be run against the port production
environment(using a testing org). </h4>

### Core testing checklist

- [ ] Integration able to create all default resources from scratch
- [ ] Resync finishes successfully
- [ ] Resync able to create entities
- [ ] Resync able to update entities
- [ ] Resync able to detect and delete entities
- [ ] Scheduled resync able to abort existing resync and start a new one
- [ ] Tested with at least 2 integrations from scratch
- [ ] Tested with Kafka and Polling event listeners
- [ ] Tested deletion of entities that don't pass the selector


### Integration testing checklist

- [ ] Integration able to create all default resources from scratch
- [ ] Resync able to create entities
- [ ] Resync able to update entities
- [ ] Resync able to detect and delete entities
- [ ] Resync finishes successfully
- [ ] If new resource kind is added or updated in the integration, add
example raw data, mapping and expected result to the `examples` folder
in the integration directory.
- [ ] If resource kind is updated, run the integration with the example
data and check if the expected result is achieved
- [ ] If new resource kind is added or updated, validate that
live-events for that resource are working as expected
- [ ] Docs PR link [here](#)

### Preflight checklist

- [ ] Handled rate limiting
- [ ] Handled pagination
- [ ] Implemented the code in async
- [ ] Support Multi account

## Screenshots
Previous State
<img width="888" alt="Screenshot 2024-10-25 at 1 59 29 PM (1)"
src="https://github.com/user-attachments/assets/670f91d9-4e58-44d5-a082-821ad0b5c65f">

Fix

![Fix](https://github.com/user-attachments/assets/c3bdb408-eb05-4768-9bd2-cb8039a6d0d1)

---------

Co-authored-by: PagesCoffy <[email protected]>
Co-authored-by: Tom Tankilevitch <[email protected]>
  • Loading branch information
3 people authored Oct 31, 2024
1 parent f0efd1e commit d3facc9
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 2 deletions.
2 changes: 1 addition & 1 deletion integrations/aws/.port/resources/port-app-config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ resources:
email: .Email
status: .Status
joined_method: .JoinedMethod
joined_timestamp: .JoinedTimestamp
joined_timestamp: .JoinedTimestamp | sub(" "; "T")

- kind: AWS::S3::Bucket
selector:
Expand Down
6 changes: 6 additions & 0 deletions integrations/aws/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

<!-- towncrier release notes start -->

## 0.2.52 (2024-10-30)

### Bug Fixes

- Updated `joined_timestamp` mapping in AWS Organizations to comply with RFC3339 timestamp format by replacing the space delimiter with 'T' in the `JoinedTimestamp` field.

## 0.2.51 (2024-10-23)


Expand Down
2 changes: 1 addition & 1 deletion integrations/aws/pyproject.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[tool.poetry]
name = "aws"
version = "0.2.51"
version = "0.2.52"
description = "This integration will map all your resources in all the available accounts to your Port entities"
authors = ["Shalev Avhar <[email protected]>", "Erik Zaadi <[email protected]>"]

Expand Down

0 comments on commit d3facc9

Please sign in to comment.