[CI/CD] auto-tag main on merge #1126
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to filter out only if |
erikzaadi
reviewed
Nov 17, 2024
.github/workflows/tag-main.yml
Outdated
| echo "Version has not changed. Skipping tagging." | ||
| exit 0 | ||
| fi | ||
| git tag "v${current_tag}" |
There was a problem hiding this comment.
For releases, tags should always be verbosely annotated
Suggested change
| git tag "v${current_tag}" | |
| LATEST_COMMIT_MESSAGE=$(git log -1 --pretty=format:%s) | |
| git tag -a "v${current_tag}" -m "${LATEST_COMMIT_MESSAGE}" |
.github/workflows/tag-main.yml
Outdated
| run: | | ||
| # Get the current version from pyproject.toml | ||
| CURRENT_TAG=$(grep -E '^version = ".*"' pyproject.toml | cut -d'"' -f2) | ||
| echo "current_tag=$CURRENT_TAG" >> $GITHUB_ENV |
There was a problem hiding this comment.
Suggested change
| echo "current_tag=$CURRENT_TAG" >> $GITHUB_ENV | |
| echo "current_tag=${CURRENT_TAG}" >> $GITHUB_ENV |
.github/workflows/tag-main.yml
Outdated
| run: | | ||
| # Get the version from the previous commit for comparison | ||
| PREV_TAG=$(git show HEAD~1:pyproject.toml | grep -E '^version = ".*"' | cut -d'"' -f2) | ||
| echo "prev_tag=$PREV_TAG" >> $GITHUB_ENV |
There was a problem hiding this comment.
Suggested change
| echo "prev_tag=$PREV_TAG" >> $GITHUB_ENV | |
| echo "prev_tag=${PREV_TAG}" >> $GITHUB_ENV |
.github/workflows/tag-main.yml
Outdated
|
|
||
| - name: Tag main | ||
| run: | | ||
| if [ "$current_tag" == "$prev_tag" ]; then |
There was a problem hiding this comment.
Suggested change
| if [ "$current_tag" == "$prev_tag" ]; then | |
| if [ "${current_tag}" == "${prev_tag}" ]; then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What - automate tagging main branch
Why - it's annoying to redo it manually each time
How - using github action
Type of change
Please leave one option from the following and delete the rest:
All tests should be run against the port production environment(using a testing org).
Core testing checklist
Integration testing checklist
examplesfolder in the integration directory.Preflight checklist
Screenshots
Include screenshots from your environment showing how the resources of the integration will look.
API Documentation
Provide links to the API documentation used for this integration.