Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Fix memory leak due to repetitive registration of FastAPI routes #1141

Merged
merged 4 commits into from
Nov 12, 2024

Conversation

talsabagport
Copy link
Contributor

Description

What - Fix memory leak due to repetitive registration of FastAPI routes

Why - Constant memory leak when registering FastAPI routes

How - Run app setup just once

Type of change

Please leave one option from the following and delete the rest:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • New Integration (non-breaking change which adds a new integration)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Non-breaking change (fix of existing functionality that will not change current behavior)
  • Documentation (added/updated documentation)

All tests should be run against the port production environment(using a testing org).

Core testing checklist

  • Integration able to create all default resources from scratch
  • Resync finishes successfully
  • Resync able to create entities
  • Resync able to update entities
  • Resync able to detect and delete entities
  • Scheduled resync able to abort existing resync and start a new one
  • Tested with at least 2 integrations from scratch
  • Tested with Kafka and Polling event listeners
  • Tested deletion of entities that don't pass the selector

@talsabagport talsabagport requested a review from a team as a code owner November 12, 2024 08:56
@talsabagport talsabagport changed the title Fix memory leak due to repetitive registration of FastAPI routes [Core] Fix memory leak due to repetitive registration of FastAPI routes Nov 12, 2024
Copy link
Contributor

@shalev007 shalev007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@talsabagport talsabagport merged commit c442cc4 into main Nov 12, 2024
22 checks passed
@talsabagport talsabagport deleted the PORT-10639-memory-leak-in-ocean branch November 12, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants