Skip to content

Commit

Permalink
refactor: remove todo comments
Browse files Browse the repository at this point in the history
  • Loading branch information
deviantony committed Sep 20, 2023
1 parent 57e348b commit 1020484
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions internal/adapter/persistentvolumeclaim.go
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,6 @@ func (adapter *KubeDockerAdapter) GetPersistentVolumeClaim(ctx context.Context,
return nil, fmt.Errorf("unable to get the system configmap associated to the persistent volume claim: %w", err)
}

// TODO: review the updatePersistentVolumeClaimFromVolume function / pattern
// if possible, review the entire converter pattern
persistentVolumeClaim, err := adapter.updatePersistentVolumeClaimFromVolume(persistentVolumeClaimConfigMap.Labels[k2dtypes.LastAppliedConfigLabelKey], persistentVolumeClaimConfigMap)
if err != nil {
return nil, fmt.Errorf("unable to update persistent volume claim from volume: %w", err)
Expand Down Expand Up @@ -153,7 +151,6 @@ func (adapter *KubeDockerAdapter) updatePersistentVolumeClaimFromVolume(persiste
return nil, fmt.Errorf("unable to convert internal object to versioned object: %w", err)
}

// TODO: review the UpdateConfigMapToPersistentVolumeClaim function / pattern
err = adapter.converter.UpdateConfigMapToPersistentVolumeClaim(&persistentVolumeClaim, configMap)
if err != nil {
return nil, fmt.Errorf("unable to convert Docker volume to PersistentVolumeClaim: %w", err)
Expand Down

0 comments on commit 1020484

Please sign in to comment.