Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

everything is working except the reset button. Pushing now, but I wil… #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Svoig
Copy link

@Svoig Svoig commented Sep 4, 2015

…l try to fix this problem as time allows

Submitting Homework 7! The reset button currently doesn't reset matched cards. I'll try to fix this as time allows, but I have to submit sooner or later.

@@ -0,0 +1,116 @@
var MemoryGui = (function() {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that you've made your cards interesting here. The only trouble is that they may be too interesting. For someone that doesn't know Russian, it's difficult to ascertain what is actually supposed to match to what here, and for testing purposes I found that I was just clicking randomly until I found something that actually matched. So, good cards, but remember that you're possibly making a game for people that don't know Russian!

Your cards are flipping, and then flipping back once two dissimilar cards are showing, which is great. There is the capability of flipping more than two cards at once, which is something you can fix by shortening the time of your hideSoon function, or by disabling clicking any time there are two cards showing.

At present your remove function doesn't seem to quite be working the way you want it to. It removes the background CSS, but retains the content of the card. Ultimately we want this function to remove the entirety of the cards content, leaving just a blank space (by removing it or rendering it invisible - and untouchable).

You're already aware of your reset button not working, but another issue with the button is that it is currently overlapping the game, so you can't help but press it while trying to get at some of the cards. I like that you've made it more interesting then just a tiny button to press, but you'll want to mess with your #reset CSS and adjust its position as necessary.

Beyond that, when I manually refresh the page the cards are being placed randomly, so that's working great.

Some minor tinkering you might do involves fixing the size of your cards. Right now they inflate or deflate based on the size of what's showing which gives the board a somewhat choppy, fluctuating quality. Minor issue, but something you can fix with a few adjustments.

Overall good work, and I hope you spend some time fixing some of these things. Let us know if you have questions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants