Add DeepCopy for AppSpec #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harsh-px
approved these changes
May 14, 2018
drivers/scheduler/spec/spec.go
Outdated
| out := new(AppSpec) | ||
| out.Key = in.Key | ||
| out.Enabled = in.Enabled | ||
| out.SpecList = make([]interface{}, len(in.SpecList)) |
There was a problem hiding this comment.
either don't initialize the slice with the length, or don't use append
There was a problem hiding this comment.
Yeah, this will result in a speclist slice of double the size of in.speclist.
The kubernetes APIs are no longer in 1.10 which causes issues in projects that vendor torpedo. The recommended way is to generate deepcopy functions, but AppSpec is simple enough.
| out.Enabled = in.Enabled | ||
| out.SpecList = make([]interface{}, 0) | ||
| for _, spec := range in.SpecList { | ||
| out.SpecList = append(out.SpecList, spec) |
There was a problem hiding this comment.
not sure how this will work when spec is a pointer
as we discussed, in future when we run tests in parallel, and modify the specs, it could be a problem
There was a problem hiding this comment.
Yes, will need to be changed when we start running tests in parallel.
There was a problem hiding this comment.
Okay; let's put a TODO here and/or create an issue to track it.
There was a problem hiding this comment.
Created Issue #166
piyush-nimbalkar
approved these changes
May 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kubernetes APIs are no longer in 1.10 which causes issues
in projects that vendor torpedo. The recommended way is to generate
deepcopy functions, but AppSpec is simple enough.