-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADD: 2023_Salazar_MachuPicchu #45
ADD: 2023_Salazar_MachuPicchu #45
Conversation
@delphis-bot create recipe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think one question that was left open in your demonstration was if the ENA sample_alias
really matches the sample names used in the publication. So I checked this by having a look into the paper and its supplementary materials. They clearly use exactly these labels 👍
Perfect! Thanks for checking Clemens! |
@delphis-bot create recipe |
Linked to #18
PR Checklist
new package
orpackage update
).Add/update package: {package_name}
.update. (Add to
Linked to #XXX
above.)If adding or updating a package:
.ssf
) for the requestedpackage.
.ssf
file(s) matches the package name (i.e.packages/2023_my_package/2023_my_package.ssf
)..ssf
file MUST contain a new line at the end of the file.A check for this exists in the CI. This check should pass before
you continue with this list.
@delphis-bot create recipe
to this pull request to awakenPoseidon's trusty helper. (This should be repeated whenever changes are
made to the SSF file contents).
Delphis-bot will then add a number of files to the PR. Check that they are all
there:
packages/{package_name}/{package_name}.tsv
was added to the PR.packages/{package_name}/{package_name}.tsv_patch.sh
was addedto the PR from template.
packages/{package_name}/script_versions.txt
was added to thePR.
packages/{package_name}/{package_name}.config
was added to thePR from template.
Human validation
Package SSF file (
*.ssf
)poseidon_IDs
,udg
, andlibrary_built
are filledand correct.
notes
where necessary to explain any specialcases/judgement calls made for data entries.
Package TSV file (
*.tsv
)UDG
,Strandedness
columns are correct for eachlibrary.
R1_target_file
andR2_target_file
columns point tothe correct FastQ files for the library (i.e. consistent with SSF file).
Package config file (
*.config
)The template config file includes a few
TODO
statements, and information aboutthem. Please ensure that you:
have added them within the
params
section at the end of the packageconfig file.