Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD: 2023_Salazar_MachuPicchu #45

Merged

Conversation

TCLamnidis
Copy link
Member

@TCLamnidis TCLamnidis commented Jul 18, 2024

Linked to #18

PR Checklist

  • Add the appropriate label to your PR (new package or package update).
  • The PR title is in the format Add/update package: {package_name}.
  • The PR description includes a link to the issue requesting the package its
    update. (Add to Linked to #XXX above.)

If adding or updating a package:

  • This PR contains a sequencingSourceFile (.ssf) for the requested
    package.
  • The name of the .ssf file(s) matches the package name (i.e.
    packages/2023_my_package/2023_my_package.ssf).
  • The .ssf file MUST contain a new line at the end of the file.
    A check for this exists in the CI. This check should pass before
    you continue with this list.
  • Comment @delphis-bot create recipe to this pull request to awaken
    Poseidon's trusty helper. (This should be repeated whenever changes are
    made to the SSF file contents).

Delphis-bot will then add a number of files to the PR. Check that they are all
there:

  • The file packages/{package_name}/{package_name}.tsv was added to the PR.
  • The file packages/{package_name}/{package_name}.tsv_patch.sh was added
    to the PR from template.
  • The file packages/{package_name}/script_versions.txt was added to the
    PR.
  • The file packages/{package_name}/{package_name}.config was added to the
    PR from template.

Human validation

Package SSF file (*.ssf)

  • I confirm that the poseidon_IDs, udg, and library_built are filled
    and correct.
  • I made sure to leave notes where necessary to explain any special
    cases/judgement calls made for data entries.

Package TSV file (*.tsv)

  • I confirm that the UDG, Strandedness columns are correct for each
    library.
  • I confirm that the R1_target_file and R2_target_file columns point to
    the correct FastQ files for the library (i.e. consistent with SSF file).

Package config file (*.config)

The template config file includes a few TODO statements, and information about
them. Please ensure that you:

  • I have selected the appropriate config for the CaptureType of the package.
  • If any nf-core/eager parameters need to be altered from their defaults, I
    have added them within the params section at the end of the package
    config file.

@TCLamnidis
Copy link
Member Author

@delphis-bot create recipe

@TCLamnidis TCLamnidis requested a review from a team July 18, 2024 09:51
Copy link
Member

@nevrome nevrome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think one question that was left open in your demonstration was if the ENA sample_alias really matches the sample names used in the publication. So I checked this by having a look into the paper and its supplementary materials. They clearly use exactly these labels 👍

@TCLamnidis
Copy link
Member Author

Perfect! Thanks for checking Clemens!

@TCLamnidis TCLamnidis merged commit f15b5b8 into poseidon-framework:main Jul 22, 2024
2 checks passed
@TCLamnidis TCLamnidis deleted the 2023_Salazar_MachuPicchu branch July 22, 2024 14:36
@TCLamnidis TCLamnidis restored the 2023_Salazar_MachuPicchu branch August 15, 2024 13:22
@TCLamnidis
Copy link
Member Author

@delphis-bot create recipe

@TCLamnidis TCLamnidis deleted the 2023_Salazar_MachuPicchu branch August 15, 2024 13:23
@TCLamnidis TCLamnidis restored the 2023_Salazar_MachuPicchu branch August 15, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants