Update package: 2023_Salazar_MacchuPicchu #50
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked to #18
The previous version of the recipe picked up the wrong input files for PE runs. Now, when BAMs including collapsed reads are uploaded to the ENA, minotaur will keep only the collapsed reads for further processing.
PR Checklist
new package
orpackage update
).Add/update package: {package_name}
.update. (Add to
Linked to #XXX
above.)If adding or updating a package:
.ssf
) for the requestedpackage.
.ssf
file(s) matches the package name (i.e.packages/2023_my_package/2023_my_package.ssf
)..ssf
file MUST contain a new line at the end of the file.A check for this exists in the CI. This check should pass before
you continue with this list.
@delphis-bot create recipe
to this pull request to awakenPoseidon's trusty helper. (This should be repeated whenever changes are
made to the SSF file contents).
Delphis-bot will then add a number of files to the PR. Check that they are all
there:
packages/{package_name}/{package_name}.tsv
was added to the PR.packages/{package_name}/{package_name}.tsv_patch.sh
was addedto the PR from template.
packages/{package_name}/script_versions.txt
was added to thePR.
packages/{package_name}/{package_name}.config
was added to thePR from template.
Human validation
Package SSF file (
*.ssf
)poseidon_IDs
,udg
, andlibrary_built
are filledand correct.
notes
where necessary to explain any specialcases/judgement calls made for data entries.
Package TSV file (
*.tsv
)UDG
,Strandedness
columns are correct for eachlibrary.
R1_target_file
andR2_target_file
columns point tothe correct FastQ files for the library (i.e. consistent with SSF file).
Package config file (
*.config
)The template config file includes a few
TODO
statements, and information aboutthem. Please ensure that you:
have added them within the
params
section at the end of the packageconfig file.