Remove the global AUXILIARY_EVENT_TX and use tracing
#80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavisVaughan
commented
Dec 3, 2024
Comment on lines
157
to
+160
| pub(crate) fn did_close( | ||
| params: DidCloseTextDocumentParams, | ||
| state: &mut WorldState, | ||
| auxiliary_event_tx: &AuxiliaryEventSender, |
There was a problem hiding this comment.
Any LSP request/notification that needs to spawn a blocking task should add a auxiliary_event_tx argument that is passed through from the top level handle_event()
It can then call things like auxiliary_event_tx.spawn_blocking_task()
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
DavisVaughan
force-pushed
the
fix/aux-global
branch
from
6407db9 to
608e9da
Compare
lionel-
approved these changes
Dec 12, 2024
DavisVaughan
changed the title
AUXILIARY_EVENT_TXAUXILIARY_EVENT_TX and use tracing
That way all you have to do to spawn a blocking task from a request handler is pass `auxiliary_event_tx` to it
DavisVaughan
force-pushed
the
fix/aux-global
branch
from
a0bb387 to
2677644
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #79
This is a first pass to completely remove
AUXILIARY_EVENT_TXin favor of passing around state to accessauxiliary_event_tx, owned byGlobalState.Currently logging is tied up in auxiliary events, which results in a net loss for ergonomics when you want to log something, as you need to pass
auxiliary_event_txaround to call itslog_error()methods.#93 is a follow up to this PR that splits the log specific events out of this, instead hooking up a tracing subscriber for logging so you can use
tracing::error!()as a free function anywhere in the LSP