Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a tracing subscriber for LSP logging #93

Merged
merged 15 commits into from
Dec 13, 2024
Merged

Use a tracing subscriber for LSP logging #93

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
8cd384e
Teach `log::` and tracing::` to send `window/logMessage` messages
DavisVaughan Dec 11, 2024
c4b669c
Put logging on its own thread
DavisVaughan Dec 11, 2024
05a4df3
Tweak existing log usage
DavisVaughan Dec 11, 2024
61881fc
Avoid logging during tests
DavisVaughan Dec 11, 2024
59db48d
Fully switch to tracing over log
DavisVaughan Dec 11, 2024
c0755b3
Send an initial log message with the level
DavisVaughan Dec 11, 2024
f6e203e
Check `AIR_LOG` envvar on startup
DavisVaughan Dec 11, 2024
8d952c7
Tweak expected option name
DavisVaughan Dec 11, 2024
e2a7858
Tweak comment
DavisVaughan Dec 11, 2024
05c3dc3
Do log during testing, but "captured" by default
DavisVaughan Dec 12, 2024
a775e77
Add intermediate `Trace*` structs with custom `Debug` implementations
DavisVaughan Dec 12, 2024
2e474a4
Use `Targets` backed filtering
DavisVaughan Dec 12, 2024
6e1cdc4
Always write the request/notify name at `info!()` level
DavisVaughan Dec 13, 2024
1ddd672
Use `pretty()` after all because it is useful with spans
DavisVaughan Dec 13, 2024
3f0f720
Write out `AIR_CRATE_NAMES` at build time
DavisVaughan Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/test-linux.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,4 +51,8 @@ jobs:
run: cargo build

- name: Run unit tests
run: cargo test
env:
AIR_LOG_LEVEL: trace
# `--nocapture` to see our own `tracing` logs
# `--test-threads 1` to ensure `tracing` logs aren't interleaved
run: cargo test -- --nocapture --test-threads 1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the just alias? I don't mind either way, I guess this is more explicit.

6 changes: 5 additions & 1 deletion .github/workflows/test-mac.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,8 @@ jobs:
run: cargo build

- name: Run unit tests
run: cargo test
env:
AIR_LOG_LEVEL: trace
# `--nocapture` to see our own `tracing` logs
# `--test-threads 1` to ensure `tracing` logs aren't interleaved
run: cargo test -- --nocapture --test-threads 1
6 changes: 5 additions & 1 deletion .github/workflows/test-windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,8 @@ jobs:
run: cargo build

- name: Run unit tests
run: cargo test
env:
AIR_LOG_LEVEL: trace
# `--nocapture` to see our own `tracing` logs
# `--test-threads 1` to ensure `tracing` logs aren't interleaved
run: cargo test -- --nocapture --test-threads 1
227 changes: 226 additions & 1 deletion Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading