-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for computing summary stats #342
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just wondering about who is responsible for formatting summary values in a nice way (see comment inline).
assert_eq!(number_stats, SummaryStatsNumber { | ||
min_value: String::from("1"), | ||
max_value: String::from("3"), | ||
mean: String::from("2"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be good to have a test with fractional values (if we do need to format on the backend side).
3abf24c
to
42b1781
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG!
#[allow(non_snake_case)] | ||
fn test_tryfrom_RObject_hashmap_i32() { | ||
r_test! { | ||
// Create a map of pizza toppings to their acceptability. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wat 😋
Addresses posit-dev/positron#3021