Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for computing summary stats #342

Merged
merged 4 commits into from
May 15, 2024
Merged

Conversation

dfalbel
Copy link
Contributor

@dfalbel dfalbel commented May 6, 2024

@dfalbel dfalbel requested a review from lionel- May 6, 2024 19:34
Copy link
Contributor

@lionel- lionel- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just wondering about who is responsible for formatting summary values in a nice way (see comment inline).

crates/ark/src/data_explorer/r_data_explorer.rs Outdated Show resolved Hide resolved
crates/ark/src/data_explorer/r_data_explorer.rs Outdated Show resolved Hide resolved
crates/ark/src/modules/positron/r_data_explorer.R Outdated Show resolved Hide resolved
crates/ark/src/modules/positron/r_data_explorer.R Outdated Show resolved Hide resolved
assert_eq!(number_stats, SummaryStatsNumber {
min_value: String::from("1"),
max_value: String::from("3"),
mean: String::from("2"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be good to have a test with fractional values (if we do need to format on the backend side).

@dfalbel dfalbel force-pushed the feature/summary_stats branch from 3abf24c to 42b1781 Compare May 10, 2024 15:32
@dfalbel dfalbel requested a review from lionel- May 10, 2024 17:58
Copy link
Contributor

@lionel- lionel- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG!

#[allow(non_snake_case)]
fn test_tryfrom_RObject_hashmap_i32() {
r_test! {
// Create a map of pizza toppings to their acceptability.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wat 😋

@dfalbel dfalbel merged commit fc9aeaf into main May 15, 2024
1 check passed
@dfalbel dfalbel deleted the feature/summary_stats branch May 15, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants