Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit the number of bins for histograms to avoid crashes #655

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

dfalbel
Copy link
Contributor

@dfalbel dfalbel commented Dec 16, 2024

Addresses: posit-dev/positron#5744 by limiting the maximum amount of bins that are returned to the front-end. This info was already provided by the front-end but we didn't respect it - instead using the result of nClass methods.

@dfalbel dfalbel requested a review from lionel- December 16, 2024 15:28
@dfalbel dfalbel merged commit e0b1620 into main Dec 17, 2024
6 checks passed
@dfalbel dfalbel deleted the bugfix/limit-histogram branch December 17, 2024 15:16
@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants