Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop or clarify color.emphasis #24

Open
gadenbuie opened this issue Oct 9, 2024 · 3 comments
Open

Drop or clarify color.emphasis #24

gadenbuie opened this issue Oct 9, 2024 · 3 comments

Comments

@gadenbuie
Copy link
Collaborator

gadenbuie commented Oct 9, 2024

We might want to make this cleaner and use color.bold and color.italic, or at least clarify how it should be used.

@gadenbuie
Copy link
Collaborator Author

gadenbuie commented Oct 9, 2024

emphasis came from Bootstrap colors:

Emphasis — For higher contrast text. Not applicable for backgrounds.

This maps to $body-emphasis-color in Bootstrap

@gadenbuie
Copy link
Collaborator Author

I think we should drop color.emphasis now and see if there's demand for a feature like this.

@gadenbuie gadenbuie changed the title color.emphasis Drop or clarify color.emphasis Oct 9, 2024
@cscheid
Copy link
Collaborator

cscheid commented Oct 10, 2024

(FYI - I'm tracking all outstanding schema changes for Quarto in https://github.com/quarto-dev/quarto-cli/tree/feature/brand-yaml-schema-consolidation/. It won't be on main until I merge, but you can follow the branch if needed)

This is fixed in Quarto by quarto-dev/quarto-cli@c5c98f2

gadenbuie added a commit that referenced this issue Oct 16, 2024
Drop `color.emphasis` #24
Drop `color.link` #26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants