feat(logo): Support alt text for logos via BrandLogoResource
#29
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #19
All paths in
logo
are now promoted toBrandLogoResource
instances. This adds a bit of overhead but makes theBrand
instance consistent, where consumers can always look in*.path
for the path to a resource which will have an adjacent, optional,.alt
property.This also means that
logo: <string>
values are promoted toBrandLogoResource
s, so consumers can expectlogo
to be either a fullBrandLogo
or a simpleBrandLogoResource
:The
examples/brand-logo-full-alt.yml
file gives a complete example with all options