This repository has been archived by the owner on Sep 13, 2024. It is now read-only.
feat: migrates creating a user using ldap #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toph-allen
approved these changes
Jul 1, 2024
| We have one user here, `Myra Francis`, username: `francism`. `francism` does not have a GUID, which means that they do not have a user account on Connect. | ||
|
|
||
| Included in the API response for each user is a `temp_ticket` value, which can be used to create the user in Connect. | ||
| The `results` object also contains a field named `temp_ticket`. |
There was a problem hiding this comment.
I think it's still important to explain that the null GUID is how you tell that a user doesn't have a Connect account.
Suggested change
| The `results` object also contains a field named `temp_ticket`. | |
| We can tell that the user `francism` does not have a user acocunt on Connect because their `guid` is `null`. The field `temp_ticket` can be used in a subsequent request to create an account on Connect. |
Comment on lines
48
to
52
| ```python | ||
| ticket = results[0]['temp_ticket'] | ||
| ``` | ||
|
|
||
| #### Creating the user | ||
| We use this value to create the user on Connect. |
There was a problem hiding this comment.
Can delete these lines (see suggestions above and below. I cannot make a suggestion here because there are unchanged lines in here).
Comment on lines
54
to
51
| ```python | ||
| response = client.put("v1/users", json={"temp_ticket": ticket}) | ||
| user = response.json() |
There was a problem hiding this comment.
Suggested change
| ```python | |
| response = client.put("v1/users", json={"temp_ticket": ticket}) | |
| user = response.json() | |
| ```python | |
| ticket = results[0]['temp_ticket'] | |
| response = client.put("v1/users", json={"temp_ticket": ticket}) | |
| user = response.json() |
tdstein
force-pushed
the
tdstein/create-user-with-ldap
branch
from
d55e11c to
1711e20
Compare
tdstein
added a commit
that referenced
this pull request
Jul 2, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that I have some in-flight work to simply the Python implementation. Here is the groups implementation. The users implementation will be similar: posit-dev/posit-sdk-py#228