Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add quartodoc website for documentation #197

Merged
merged 10 commits into from
Jun 3, 2024
Merged

docs: add quartodoc website for documentation #197

merged 10 commits into from
Jun 3, 2024

Conversation

tdstein
Copy link
Collaborator

@tdstein tdstein commented May 30, 2024

Adds a documentation site using Quartodoc. Various changes are introduced to the docstrings in order to accommodate Quartodoc nuances.

Resolves #196

Do the following to preview.

cd docs
make
make preview

Do the following to build from root, assuming deps and dev or build are ran prior.

make docs

Now that a base is established, I will do smaller PRs for incremental changes.

Copy link

github-actions bot commented May 30, 2024

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
1018 978 96% 80% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
src/posit/init.py 100% 🟢
src/posit/connect/bundles.py 100% 🟢
src/posit/connect/client.py 100% 🟢
src/posit/connect/content.py 98% 🟢
src/posit/connect/metrics/init.py 100% 🟢
src/posit/connect/metrics/usage.py 100% 🟢
src/posit/connect/permissions.py 100% 🟢
src/posit/connect/tasks.py 100% 🟢
src/posit/connect/users.py 100% 🟢
TOTAL 100% 🟢

updated for commit: 50b795f by action🐍

@tdstein tdstein force-pushed the tdstein/196 branch 2 times, most recently from e7aefc5 to bd23d53 Compare May 30, 2024 19:36
@tdstein tdstein changed the title tdstein/196 docs: add quartodoc website for documentation May 30, 2024
@tdstein tdstein marked this pull request as ready for review May 30, 2024 19:44
@tdstein
Copy link
Collaborator Author

tdstein commented May 30, 2024

The docs site is far from perfect, but this at least gets things moving.

@nealrichardson
Copy link
Collaborator

Thanks for taking this on. There's lots to improve here, but we can tackle that as we go. Might be good to bring in Greg or others that worked on Shiny's docs recently, their site looks nice and I notice they have some custom code to handle some formatting.

The one thing I'd like to see if we could solve from the beginning is the URL structure. Instead of /reference/connect.bundles.html etc., could we make that be /reference/connect/bundles.html, i.e. have the connect submodule be a subdirectory?

@tdstein
Copy link
Collaborator Author

tdstein commented May 31, 2024

The one thing I'd like to see if we could solve from the beginning is the URL structure. Instead of /reference/connect.bundles.html etc., could we make that be /reference/connect/bundles.html, i.e. have the connect submodule be a subdirectory?

Not that I have found. These URLs are configured by Quartodoc, and I do not see a way to force them to this style. @machow - do you know if this is possible?

@wydsith
Copy link

wydsith commented May 31, 2024

We should be using the Posit Theme instead of the default cosmo - https://github.com/posit-dev/product-doc-theme?tab=readme-ov-file#product-doc-theme

@tdstein
Copy link
Collaborator Author

tdstein commented May 31, 2024

We should be using the Posit Theme instead of the default cosmo - https://github.com/posit-dev/product-doc-theme?tab=readme-ov-file#product-doc-theme

Thanks! I'll add that.

docs/_quarto.yml Outdated Show resolved Hide resolved
Copy link

@wydsith wydsith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting the theme added! I think it still needs some tweaking - there's missing Footer info that has content required by Marketing/Legal. Ashley or I can poke at it if you have trouble, just let me know!

docs/index.qmd Outdated Show resolved Hide resolved

- [Requests](https://requests.readthedocs.io/en/latest/) provides the HTTP layer.

# Install Posit's SDK
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Install Posit's SDK
# Install the Posit SDK

docs/installation.qmd Outdated Show resolved Hide resolved
docs/installation.qmd Outdated Show resolved Hide resolved
docs/installation.qmd Outdated Show resolved Hide resolved
docs/quickstart.qmd Outdated Show resolved Hide resolved
docs/quickstart.qmd Outdated Show resolved Hide resolved
docs/quickstart.qmd Outdated Show resolved Hide resolved
docs/index.qmd Outdated Show resolved Hide resolved
docs/index.qmd Outdated Show resolved Hide resolved
@tdstein
Copy link
Collaborator Author

tdstein commented Jun 3, 2024

Thanks for getting the theme added! I think it still needs some tweaking - there's missing Footer info that has content required by Marketing/Legal. Ashley or I can poke at it if you have trouble, just let me know!

Thanks for the review! I ran into issues installing the theme as instructed within the Makefile. As you can see in the _quarto.yaml, I ended up directly importing the assets to get around this. I'll look into adding the footer.

@tdstein tdstein requested a review from wydsith June 3, 2024 14:50
@tdstein tdstein merged commit d289322 into main Jun 3, 2024
10 checks passed
@tdstein tdstein deleted the tdstein/196 branch June 3, 2024 15:02
@tdstein
Copy link
Collaborator Author

tdstein commented Jun 3, 2024

Will address subsequent issues in follow up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add documentation site
4 participants