Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: add v2024.06.0 to integration suite #237

Merged
merged 2 commits into from
Jul 23, 2024
Merged

build: add v2024.06.0 to integration suite #237

merged 2 commits into from
Jul 23, 2024

Conversation

tdstein
Copy link
Collaborator

@tdstein tdstein commented Jul 22, 2024

No description provided.

@github-actions GitHub Actions
Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
1116 1047 94% 0% 🟢

New Files

No new covered files...

Modified Files

No covered modified files...

updated for commit: cf005df by action🐍

kgartland-rstudio
kgartland-rstudio approved these changes Jul 22, 2024
View reviewed changes
Copy link

@kgartland-rstudio kgartland-rstudio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but instead of updating this file each release, you could use this:
https://cdn.rstudio.com/connect/supported_versions.json

@tdstein
Copy link
Collaborator Author

tdstein commented Jul 23, 2024

Approving but instead of updating this file each release, you could use this: https://cdn.rstudio.com/connect/supported_versions.json

Nice! Do you know where this is generated?

@tdstein tdstein merged commit cb71920 into main Jul 23, 2024
30 checks passed
@tdstein tdstein deleted the tdstein/update-connect-versions branch July 23, 2024 11:23
@kgartland-rstudio
Copy link

Approving but instead of updating this file each release, you could use this: https://cdn.rstudio.com/connect/supported_versions.json

Nice! Do you know where this is generated?

It's run in CI when main is updated.
https://github.com/rstudio/connect/blob/cf6f5481e4ec69b4d68646b3ac01a01d5ea531e9/.github/workflows/supported_versions.yml#L26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgartland-rstudio kgartland-rstudio kgartland-rstudio approved these changes

@nealrichardson nealrichardson nealrichardson approved these changes

@jonkeane jonkeane Awaiting requested review from jonkeane

@toph-allen toph-allen Awaiting requested review from toph-allen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tdstein @kgartland-rstudio @nealrichardson