refactor: add url class in place of urls module functions #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdstein
changed the title
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
tdstein
force-pushed
the
tdstein/improve-url-parsing
branch
from
db5fb68 to
f1f13ea
Compare
|
The changes look fine to me and slightly less boiler plate which is nice. Would you mind adding a description to the PR with pros / cons for the historical record? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new class,
urls.Url, which wraps the existingurls.createandurls.appendmethods. This alleviates the need toimport .urlsin most situations (see #246).The new class
urls.Urlsupports Python append via the special method__add__. This is convenient for appending paths to the base endpoint. (e.g.,new_url = base_url + '/path').