Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace restart environment variable hash with unix epoch #251

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

tdstein
Copy link
Collaborator

@tdstein tdstein commented Jul 31, 2024

The hash was introduced to reduce the chance of collisions with existing environment variables introduced by the user or another restart invocation. A UNIX epoch provides similar collision protection while providing additional metadata for debugging if the unset routine fails.

@tdstein tdstein requested review from toph-allen and jonkeane July 31, 2024 15:52
Copy link

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
1229 1162 95% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
src/posit/connect/content.py 100% 🟢
TOTAL 100% 🟢

updated for commit: 8a11edf by action🐍

Copy link
Collaborator

@toph-allen toph-allen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@tdstein tdstein merged commit 8648f80 into main Jul 31, 2024
30 checks passed
@tdstein tdstein deleted the tdstein/use-timestamp-in-restart branch July 31, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants