refactor!: drop support field access by attribute. #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New Files
Modified Files
|
tdstein
changed the title
tdstein
changed the title
tdstein
force-pushed
the
tdstein/262-remove-deprecated-resource-properties
branch
from
8b2d080 to
895d996
Compare
Removes all @Property annotated methods used for direct field access on concrete resources. A new __getattr__ implementation is added to Resource to maintain backwards compatiblity. This implementation calls __getitem__ when the key exists in self. A noisy deprecation warning is issued to alert users that this functionality will be removed in v1.0.0.
BREAKING CHANGE: removes support for accessing resource fields using `__getattr__` (e.g., `user.username`). Use `__getitem__` instead (e.g., `user["username"]`.
tdstein
force-pushed
the
tdstein/262-remove-deprecated-resource-properties
branch
from
895d996 to
43bb863
Compare
tdstein
force-pushed
the
release/v1.0.0
branch
from
c44301b to
77941bb
Compare
toph-allen
approved these changes
Sep 9, 2024
tdstein
deleted the
tdstein/262-remove-deprecated-resource-properties
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: removes support for accessing resource fields using
__getattr__(e.g.,user.username). Use__getitem__instead (e.g.,user["username"].depends on #265 and #266
closes #262