Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: Lint testing folders #326

Merged
merged 4 commits into from
Nov 8, 2024
Merged

style: Lint testing folders #326

merged 4 commits into from
Nov 8, 2024

Conversation

schloerke
Copy link
Collaborator

Pylance was flagging many lines. Added tests folder into the type checker.

@schloerke schloerke requested a review from tdstein as a code owner November 8, 2024 17:05
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2024 •
edited
Loading

☂️ Python Coverage

current status: ✅

Overall Coverage

Lines Covered Coverage Threshold Status
1647 1515 92% 0% 🟢

New Files

No new covered files...

Modified Files

File Coverage Status
src/posit/connect/content.py 96% 🟢
TOTAL 96% 🟢

updated for commit: 2ac7dfd by action🐍

@schloerke schloerke changed the title Lint tests folder tests: Lint tests folder Nov 8, 2024
@schloerke schloerke changed the title tests: Lint tests folder style: Lint tests folder Nov 8, 2024
tdstein
tdstein approved these changes Nov 8, 2024
View reviewed changes
Copy link
Collaborator

@tdstein tdstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! It may be worth linting integration/tests as well.

@schloerke
Copy link
Collaborator Author

Yes. Great idea

@schloerke schloerke changed the title style: Lint tests folder style: Lint testing folders Nov 8, 2024
@schloerke schloerke merged commit 7236487 into zack-192-git-repo-settings Nov 8, 2024
33 checks passed
@schloerke schloerke deleted the test_lints branch November 8, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tdstein tdstein tdstein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schloerke @tdstein