Skip to content

Commit

Permalink
Fix R restart test with new Kallichore build (#5387)
Browse files Browse the repository at this point in the history
Addresses #5356; fixes
restarts on R and re-enables the R console tests.

The bug was upstream, in the supervisor; the issue was that during a
restart, the channel that broadcast status updates to the client would
blink offline. If the 'starting' status got sent during that blink, the
client would miss it and not detect startup correctly. The fix is to
ensure the channel always broadcasts updates throughout the restart
cycle.

### QA Notes

As noted by @jonvanausdeln, this is 100% reproducible on Windows, so it
should be easy to test the fix there.
  • Loading branch information
jmcphers authored Nov 15, 2024
1 parent 34695a1 commit 39536c2
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
2 changes: 1 addition & 1 deletion extensions/positron-supervisor/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@
},
"positron": {
"binaryDependencies": {
"kallichore": "0.1.18"
"kallichore": "0.1.19"
}
},
"dependencies": {
Expand Down
3 changes: 1 addition & 2 deletions test/smoke/src/areas/positron/console/r-console.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,7 @@ import { expect } from '@playwright/test';
import { Application, PositronRFixtures } from '../../../../../automation';
import { setupAndStartApp } from '../../../test-runner/test-hooks';

// Skipping due to https://github.com/posit-dev/positron/issues/5356
describe.skip('Console Pane: R', () => {
describe('Console Pane: R', () => {
setupAndStartApp();

describe('R Console Restart #web #win', () => {
Expand Down

0 comments on commit 39536c2

Please sign in to comment.