Make date summary stats optional

posit-dev · Sep 30, 2024 · a699585 · a699585
1 parent 659e073
commit a699585
Show file tree

Hide file tree

Showing 3 changed files with 32 additions and 34 deletions.
diff --git a/extensions/positron-python/python_files/positron/positron_ipykernel/data_explorer_comm.py b/extensions/positron-python/python_files/positron/positron_ipykernel/data_explorer_comm.py
@@ -744,23 +744,28 @@ class SummaryStatsDate(BaseModel):
     SummaryStatsDate in Schemas
     """
 
-    num_unique: StrictInt = Field(
+    num_unique: Optional[StrictInt] = Field(
+        default=None,
         description="The exact number of distinct values",
     )
 
-    min_date: StrictStr = Field(
+    min_date: Optional[StrictStr] = Field(
+        default=None,
         description="Minimum date value as string",
     )
 
-    mean_date: StrictStr = Field(
+    mean_date: Optional[StrictStr] = Field(
+        default=None,
         description="Average date value as string",
     )
 
-    median_date: StrictStr = Field(
+    median_date: Optional[StrictStr] = Field(
+        default=None,
         description="Sample median (50% value) date value as string",
     )
 
-    max_date: StrictStr = Field(
+    max_date: Optional[StrictStr] = Field(
+        default=None,
         description="Maximum date value as string",
     )
 
@@ -770,23 +775,28 @@ class SummaryStatsDatetime(BaseModel):
     SummaryStatsDatetime in Schemas
     """
 
-    num_unique: StrictInt = Field(
+    num_unique: Optional[StrictInt] = Field(
+        default=None,
         description="The exact number of distinct values",
     )
 
-    min_date: StrictStr = Field(
+    min_date: Optional[StrictStr] = Field(
+        default=None,
         description="Minimum date value as string",
     )
 
-    mean_date: StrictStr = Field(
+    mean_date: Optional[StrictStr] = Field(
+        default=None,
         description="Average date value as string",
     )
 
-    median_date: StrictStr = Field(
+    median_date: Optional[StrictStr] = Field(
+        default=None,
         description="Sample median (50% value) date value as string",
     )
 
-    max_date: StrictStr = Field(
+    max_date: Optional[StrictStr] = Field(
+        default=None,
         description="Maximum date value as string",
     )
 

diff --git a/positron/comms/data_explorer-backend-openrpc.json b/positron/comms/data_explorer-backend-openrpc.json
@@ -1043,13 +1043,7 @@
 			},
 			"summary_stats_date": {
 				"type": "object",
-				"required": [
-					"num_unique",
-					"min_date",
-					"mean_date",
-					"median_date",
-					"max_date"
-				],
+				"required": [],
 				"properties": {
 					"num_unique": {
 						"type": "integer",
@@ -1075,13 +1069,7 @@
 			},
 			"summary_stats_datetime": {
 				"type": "object",
-				"required": [
-					"num_unique",
-					"min_date",
-					"mean_date",
-					"median_date",
-					"max_date"
-				],
+				"required": [],
 				"properties": {
 					"num_unique": {
 						"type": "integer",

diff --git a/src/vs/workbench/services/languageRuntime/common/positronDataExplorerComm.ts b/src/vs/workbench/services/languageRuntime/common/positronDataExplorerComm.ts
@@ -608,27 +608,27 @@ export interface SummaryStatsDate {
 	/**
 	 * The exact number of distinct values
 	 */
-	num_unique: number;
+	num_unique?: number;
 
 	/**
 	 * Minimum date value as string
 	 */
-	min_date: string;
+	min_date?: string;
 
 	/**
 	 * Average date value as string
 	 */
-	mean_date: string;
+	mean_date?: string;
 
 	/**
 	 * Sample median (50% value) date value as string
 	 */
-	median_date: string;
+	median_date?: string;
 
 	/**
 	 * Maximum date value as string
 	 */
-	max_date: string;
+	max_date?: string;
 
 }
 
@@ -639,27 +639,27 @@ export interface SummaryStatsDatetime {
 	/**
 	 * The exact number of distinct values
 	 */
-	num_unique: number;
+	num_unique?: number;
 
 	/**
 	 * Minimum date value as string
 	 */
-	min_date: string;
+	min_date?: string;
 
 	/**
 	 * Average date value as string
 	 */
-	mean_date: string;
+	mean_date?: string;
 
 	/**
 	 * Sample median (50% value) date value as string
 	 */
-	median_date: string;
+	median_date?: string;
 
 	/**
 	 * Maximum date value as string
 	 */
-	max_date: string;
+	max_date?: string;
 
 	/**
 	 * Time zone for timestamp with time zone