Enqueue notebook renderer webview renders immediately (#4475)

This is another attempt to fix the failing smoke tests for IPyWidget plots (#4448). We probably should have always been calling `enqueue` instead of `enqueueIdle`, since we only render a single output item in our notebook output webviews. I also enabled renderer logging for debugging issues like this in future. ### QA Notes Plot tests in the full test suite passed 6 times on this branch: https://github.com/posit-dev/positron/actions/runs/10529737503.
posit-dev · Aug 26, 2024 · ac7fdd2 · ac7fdd2
1 parent 9faaed1
commit ac7fdd2
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 9 deletions.
diff --git a/src/vs/workbench/contrib/notebook/browser/view/renderers/webviewPreloads.ts b/src/vs/workbench/contrib/notebook/browser/view/renderers/webviewPreloads.ts
@@ -1638,7 +1638,7 @@ async function webviewPreloads(ctx: PreloadContext) {
 			// --- Start Positron ---
 			case 'positronRender': {
 				const data = event.data;
-				outputRunner.enqueueIdle(data.outputId, async signal => {
+				outputRunner.enqueue(data.outputId, async signal => {
 					// Get the element to render into.
 					const element = document.getElementById(data.elementId);
 					if (!element) {

diff --git a/src/vs/workbench/contrib/positronOutputWebview/browser/notebookOutputWebview.ts b/src/vs/workbench/contrib/positronOutputWebview/browser/notebookOutputWebview.ts
@@ -18,6 +18,7 @@ import { FromWebviewMessage, IClickedDataUrlMessage } from 'vs/workbench/contrib
 import { IScopedRendererMessaging } from 'vs/workbench/contrib/notebook/common/notebookRendererMessagingService';
 import { INotebookOutputWebview } from 'vs/workbench/contrib/positronOutputWebview/browser/notebookOutputWebviewService';
 import { IOverlayWebview, IWebviewElement } from 'vs/workbench/contrib/webview/browser/webview';
+import { INotebookLoggingService } from 'vs/workbench/contrib/notebook/common/notebookLoggingService';
 
 interface NotebookOutputWebviewOptions<WType extends IOverlayWebview | IWebviewElement = IOverlayWebview> {
 	readonly id: string;
@@ -70,6 +71,7 @@ export class NotebookOutputWebview<WType extends IOverlayWebview | IWebviewEleme
 		@IFileService private _fileService: IFileService,
 		@IWorkspaceContextService private _workspaceContextService: IWorkspaceContextService,
 		@ILogService private _logService: ILogService,
+		@INotebookLoggingService private _notebookLogService: INotebookLoggingService,
 		@INotificationService private _notificationService: INotificationService,
 	) {
 		super();
@@ -109,6 +111,14 @@ export class NotebookOutputWebview<WType extends IOverlayWebview | IWebviewEleme
 				case 'customRendererMessage':
 					rendererMessaging?.postMessage(data.rendererId, data.message);
 					break;
+				case 'logRendererDebugMessage':
+					this._notebookLogService.debug(
+						'NotebookOutputWebview',
+						`${this.sessionId} (${this.id}) - ` +
+							data.message +
+							data.data ? ' ' + JSON.stringify(data.data, null, 4) : ''
+					);
+					break;
 				case 'positronRenderComplete':
 					this._onDidRender.fire();
 					break;

diff --git a/test/smoke/src/areas/positron/plots/plots.test.ts b/test/smoke/src/areas/positron/plots/plots.test.ts
@@ -304,8 +304,7 @@ plt.show()`;
 				await app.workbench.positronPlots.waitForNoPlots();
 			});
 
-			// skipping for now as we have intermittent issues with blank plots appearing
-			it.skip('Python - Verifies bqplot Python widget [C720869]', async function () {
+			it('Python - Verifies bqplot Python widget [C720869]', async function () {
 				const app = this.app as Application;
 
 				const script = `import bqplot.pyplot as bplt
@@ -326,8 +325,7 @@ bplt.show()`;
 
 			});
 
-			// skipping for now as we have intermittent issues with blank plots appearing
-			it.skip('Python - Verifies ipydatagrid Python widget [C720870]', async function () {
+			it('Python - Verifies ipydatagrid Python widget [C720870]', async function () {
 				const app = this.app as Application;
 
 				const script = `import pandas as pd
@@ -340,8 +338,7 @@ DataGrid(data, selection_mode="cell", editable=True)`;
 
 			});
 
-			// skipping for now as we have intermittent issues with blank plots appearing
-			it.skip('Python - Verifies ipyleaflet Python widget [C720871]', async function () {
+			it('Python - Verifies ipyleaflet Python widget [C720871]', async function () {
 				const app = this.app as Application;
 
 				const script = `from ipyleaflet import Map, Marker, display
@@ -359,8 +356,7 @@ display(map)`;
 
 			});
 
-			// skipping for now as we have intermittent issues with blank plots appearing
-			it.skip('Python - Verifies ipytree Python widget [C720872]', async function () {
+			it('Python - Verifies ipytree Python widget [C720872]', async function () {
 				const app = this.app as Application;
 
 				const script = `from ipytree import Tree, Node