-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fastapi display in viewer does not work on Ubuntu #4949
Comments
FYI @seeM @isabelizimm |
On my windows box I get
|
@jonvanausdeln this looks like a separate Windows-specific issue where our conversion from a file path ( I'm not yet sure what's happening in the Ubuntu case. |
@seeM , should I open a separate issue for windows? |
@jonvanausdeln yes I think so |
@testlabauto was this intermittent or consistently reproducible? I wonder if this is the same issue as #5187. I re-enabled the Fastapi test in #5265 which passed in the PR test run. |
- addresses #5187 - ❓ possibly also addresses #4949 ### Implementation Notes - adds optional `appReadyMessage` property to `RunAppOptions` and `DebugAppOptions` - specify an `appReadyMessage` of `'Application startup complete'` for FastAPI and Shiny apps, which leverage uvicorn and output that message when the app is ready - delete empty `DebugConfiguration` object from the `positron-run-app.d.ts` files, as I think they are unused? - modified the logging level in `api.ts` for a few messages - `previewUrlInExecutionOutput` now checks for both the app url and the `appReadyMessage` if provided, - an app is considered ready if: - the `appReadyMessage` was not provided and the app url has been matched; or - the `appReadyMessage` was provided and matched, and the app url has been matched - if the `appReadyMessage` was provided but not matched, and the app url has been matched, we'll time out of the `raceTimeout`, but the url will have been matched, so we'll still try to open the app in the Viewer ### QA Notes - I've renabled `Python - Verify Basic FastAPI App [C903306]` which now passes - Please use the repro steps from the issue: #5187
- addresses #5187 - ❓ possibly also addresses #4949 ### Implementation Notes - adds optional `appReadyMessage` property to `RunAppOptions` and `DebugAppOptions` - specify an `appReadyMessage` of `'Application startup complete'` for FastAPI and Shiny apps, which leverage uvicorn and output that message when the app is ready - delete empty `DebugConfiguration` object from the `positron-run-app.d.ts` files, as I think they are unused? - modified the logging level in `api.ts` for a few messages - `previewUrlInExecutionOutput` now checks for both the app url and the `appReadyMessage` if provided, - an app is considered ready if: - the `appReadyMessage` was not provided and the app url has been matched; or - the `appReadyMessage` was provided and matched, and the app url has been matched - if the `appReadyMessage` was provided but not matched, and the app url has been matched, we'll time out of the `raceTimeout`, but the url will have been matched, so we'll still try to open the app in the Viewer ### QA Notes - I've renabled `Python - Verify Basic FastAPI App [C903306]` which now passes - Please use the repro steps from the issue: #5187
Verified Fixed
Test scenario(s)Marking as verified based on CI test passing now! Link(s) to TestRail test cases run or created: |
System details:
Positron and OS details:
Ubuntu 24.04
Positron 2024.11.0 build 16
Interpreter details:
Python 3.10.12
Describe the issue:
The fastapi_example from qa-example-content does not render in the Viewer on Ubuntu.
Steps to reproduce the issue:
Expected or desired behavior:
FastAPI example works
Were there any error messages in the UI, Output panel, or Developer Tools console?
Uncaught SyntaxError: Identifier 'hostMessaging' has already been declared
The text was updated successfully, but these errors were encountered: