check for appReadyMessage before previewing app #5265
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation Notes
appReadyMessage
property toRunAppOptions
andDebugAppOptions
appReadyMessage
of'Application startup complete'
for FastAPI and Shiny apps, which leverage uvicorn and output that message when the app is readyDebugConfiguration
object from thepositron-run-app.d.ts
files, as I think they are unused?api.ts
for a few messagespreviewUrlInExecutionOutput
now checks for both the app url and theappReadyMessage
if provided,appReadyMessage
was not provided and the app url has been matched; orappReadyMessage
was provided and matched, and the app url has been matchedappReadyMessage
was provided but not matched, and the app url has been matched, we'll time out of theraceTimeout
, but the url will have been matched, so we'll still try to open the app in the ViewerQA Notes
Python - Verify Basic FastAPI App [C903306]
which now passes