Exclude exited sessions when detecting active console session #2554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jennifer (Jenny) Bryan <[email protected]> Signed-off-by: Jonathan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent
Addresses #2553.
This is a regression from the multi-session work; the problem is that in some cases, the R language pack can try to send commands to a previous console session instead of the current one.
Approach
The fix is to ignore exited console sessions when attempting to figure out which one we should talk to when sending commands such as Format Document.
I've also added some defensiveness around multiple console sessions; if this ever happens, we warn and return whichever is newest.
QA Notes
Test via notes in #2553.