Feature/add edit filters through filter bar #2591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great step forward Brian! Should we log keyboard navigation through these filter pop-ups as a follow-on task? |
jmcphers
approved these changes
Apr 1, 2024
...Explorer/components/dataExplorerPanel/components/rowFilterBar/components/rowFilterWidget.tsx
Show resolved
Hide resolved
nstrayer
approved these changes
Apr 1, 2024
src/vs/workbench/browser/positronComponents/positronModalPopup/positronModalPopup.tsx
Outdated
Show resolved
Hide resolved
...nents/dataExplorerPanel/components/addEditRowFilterModalPopup/addEditRowFilterModalPopup.tsx
Outdated
Show resolved
Hide resolved
...nents/dataExplorerPanel/components/addEditRowFilterModalPopup/addEditRowFilterModalPopup.tsx
Outdated
Show resolved
Hide resolved
...nents/dataExplorerPanel/components/addEditRowFilterModalPopup/addEditRowFilterModalPopup.tsx
Outdated
Show resolved
Hide resolved
...r/positronDataExplorer/components/dataExplorerPanel/components/rowFilterBar/rowFilterBar.tsx
Show resolved
Hide resolved
Yes! I am saving some of this smaller kind of work for after April 12th when I will need bite-sized chunks of work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains Data Explorer UI work that allows row filters to be added and edited. Here's a movie of this in action.
Screen.Recording.2024-03-29.at.9.45.10.PM.mov