Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily disable pip package snapshot CI tests #2596

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

wesm
Copy link
Contributor

@wesm wesm commented Apr 1, 2024

polars forces a downgrade of the typing_extensions library which breaks newer IPython in CI:

 Collecting typing_extensions>=4.0.1 (from polars->-r pythonFiles/positron/data-science-requirements.txt (line 2))
  Downloading https://packagemanager.rstudio.com/pypi/2023-04-01/packages/typing-extensions/fb33085c39dd998ac16d1431ebc293a8b3eedd00fd4a32de0ff79002c19511b4/typing_extensions-4.5.0-py3-none-any.whl (27 kB)

See for example

https://github.com/posit-dev/positron/actions/runs/8514455041/job/23320206526?pr=2593

This temporarily disables these tests until we can sort out a proper fix to unblock other PRs. It also makes sure that these tests run when the CI configuration changes.

@wesm
Copy link
Contributor Author

wesm commented Apr 1, 2024

torch also forced the downgrade. I'll try not letting pip downgrade any dependencies

@wesm wesm changed the title Remove polars from historical version tests because of breaking CI Do not downgrade Python dependencies when running historical version tests Apr 1, 2024
@wesm wesm force-pushed the bug/polars-typing-extensions-dep-break branch from e5b7d9c to 02d331f Compare April 1, 2024 23:22
Add polars back

Also test if CI configuration has changed

Temporarily disable snapshot CI tests

Temporarily disable snapshot CI tests
@wesm wesm force-pushed the bug/polars-typing-extensions-dep-break branch from 02d331f to 2d349b3 Compare April 1, 2024 23:24
@wesm wesm changed the title Do not downgrade Python dependencies when running historical version tests Temporarily disable pip package snapshot CI tests Apr 1, 2024
@wesm wesm merged commit 4ead84b into main Apr 1, 2024
23 checks passed
@wesm wesm deleted the bug/polars-typing-extensions-dep-break branch April 1, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant