Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix/occluding viewer panes #2608

Merged
merged 3 commits into from
Apr 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,13 @@ export class PositronHelpView extends ViewPane implements IReactComponentContain
@IThemeService themeService: IThemeService,
@IViewDescriptorService viewDescriptorService: IViewDescriptorService
) {
// Override minimum size option if it isn't already somehow set. There doesn't seem to be a
// way to set this in any sort of configuration hence the need to override it here. If this
// isn't set, then the help pane will occlude parts of the editor when it is resized to be
// very small.
// TODO: See about disposing the webview entirely when the size is too small to see.
options = { ...options, minimumBodySize: 0 };

// Call the base class's constructor.
super(
options,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,10 @@ export class PositronPreviewViewPane extends ViewPane implements IReactComponent
@IWorkbenchLayoutService private readonly layoutService: IWorkbenchLayoutService,
@IPositronPreviewService private readonly positronPreviewService: IPositronPreviewService
) {
// Override minimum size option if it isn't already somehow set. See `PositronHelpView` for
// more context.
options = { ...options, minimumBodySize: 0 };

super(options, keybindingService, contextMenuService, configurationService, contextKeyService, viewDescriptorService, instantiationService, openerService, themeService, telemetryService);
this._register(this.onDidChangeBodyVisibility(() => this.onDidChangeVisibility(this.isBodyVisible())));
this._positronPreviewContainer = DOM.$('.positron-preview-container');
Expand Down
Loading