Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 1.88 from upstream #2665

Merged
merged 1,373 commits into from
Apr 16, 2024
Merged

Merge 1.88 from upstream #2665

merged 1,373 commits into from
Apr 16, 2024

Conversation

jmcphers
Copy link
Collaborator

@jmcphers jmcphers commented Apr 4, 2024

Merges 1.88 from upstream; see upstream release notes: https://github.com/microsoft/vscode/releases/tag/1.88.0

Notes:

  • the way codicons are injected has changed; now the codicon mapping file is auto-generated. some changes to accommodate this were necessary on the positron-codicons repository.
  • node version got bumped; now we need 18.19
  • typescript version got bumped, resulting in a bunch of warnings in positron-python that had to be silenced with // @ts-ignore
  • webviews now require an owning CodeWindow to claim an overlay
  • an editor group must now be supplied when instantiating an EditorPane

aiday-mar and others added 30 commits March 21, 2024 17:01
…owFunctionUsed

Indent next line when arrow function arrow followed by whitespace
* Add missing css variable in vscode-known-variables.json

* Better highlight color for test explorer retired icon

* Add testingRetiredCorlor for different icon state

* Use derived value from non-retired color variable instead of string literals
* fix legacy builds

* update regex

* extra ?

* argh
Adding a test in the auto-indentation test suite
* cli: allow downloading legacy servers for older glibc versions

Refs #206790

* chore: update asset name

---------

Co-authored-by: deepak1556 <[email protected]>
Reveal the current session command in run recent
Don't add to already disposed store
Terminal shell integration proposed api
@jmcphers jmcphers requested a review from petetronic April 4, 2024 22:51
@petetronic
Copy link
Collaborator

Mac OS looked good, just needing to update Windows and test

@jmcphers
Copy link
Collaborator Author

jmcphers commented Apr 5, 2024

Mac OS looked good, just needing to update Windows and test

If you need a pre-built Windows installer, there's one attached as an artifact to this build: https://github.com/posit-dev/positron/actions/runs/8562226646

(ignore the macOS build failure there, it should be resolved in the next release run)

@petetronic
Copy link
Collaborator

Built windows locally too, after an initial issue with pandas backed dataframes, rebuilding a second time, things looked fine.

@jmcphers jmcphers merged commit 346eda5 into main Apr 16, 2024
24 checks passed
@jmcphers jmcphers deleted the merge/1.88.0 branch April 16, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.