Apply positron-python updates from vscode-python v2024.4.0 #2678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesm
changed the title
|
@isabelizimm @petetronic this is ready for tire-kicking -- I built locally and nothing seemed obviously broken. I mentioned there were some pyenv related changes and so we may need to take a closer look at that in environmentTypeComparers.ts as follow up work. Regarding the actual merge: I'm not big on merge commits in general, and since we aren't technically "merging" anything here but rather applying a sequence of patches -- we replayed the upstream history onto this repository -- a rebase-and-push would be superior in my view but I will defer to the wishes of others. I'm just going to roll up the fixes I made into a single commit now that the CI has passed. |
wesm
force-pushed
the
vscode-python-v2024.4.0
branch
from
4b9a7b9 to
3d5a751
Compare
isabelizimm
approved these changes
Apr 5, 2024
…vscode-python#22966) Failing tests are not related to the PR, so this is ready for review. For microsoft/vscode-python#22877
Short-term fix to stop CI from failing due to a regression upstream from pytest. See issue for details: microsoft/vscode-python#22965.
Bump release 2024.2
Part of microsoft/vscode-jupyter#14977 Removes some effectively dead code that would only be used by very old (year+) versions of Pylance. This logic has all been moved into vscode-pylance: - Middleware to make the interactive window input box look like a notebook cell - Call to Jupyter to get pythonpath for notebooks. - Configuration hook to get `[python]` value of `editor.formatOnType`. - LSP notebook experiment
Closes microsoft/vscode-python#22994 closes microsoft/vscode-python#22993 Temporarily build our own known cache from which we return envs instead.
add calendar for primary and secondary release champ
…hon#22964) Failing tests are due to microsoft/vscode-python#22965, this can still be reviewed. Closes microsoft/vscode-python#22918 closes microsoft/vscode-python#22146
- Adding the Python Debugger extension to the `devcontainer.json` extensions. - Small hygiene updates and removing mention of built linting and formatting support on `README.md`. --------- Co-authored-by: Luciana Abud <[email protected]>
Co-authored-by: Karthik Nadig <[email protected]> Co-authored-by: eleanorjboyd <[email protected]>
Also set the line length to 100.
Use new report issue command api microsoft/vscode-python-debugger#237 Modify the template, information about the installed extensions was added
…3076) Closes microsoft/vscode-python#22988 closes microsoft/vscode-python#23070 Changes Python environments cache key
Forgot to set default value to true here: microsoft/vscode-python#23067 It was true before removing experiment code since we had experiment to 100%, which effectively overrode the smart send setting value to True.
Fixes microsoft/vscode-python#22810 TODO - [x] check if it actually works already or if more things need to be registered - [x] add config val - [x] add tests
…ython#23080) Closes microsoft/vscode-python#22956 Because we calculate `PS1` ourselves due to a limitation: microsoft/vscode-python#22078, this environment variable may not end up being respected as do not use `PS1`. This PR fixes it.
…rom locator (microsoft/vscode-python#23083) For microsoft/vscode-python#22810 ...so in case of Hatch, as an [explicit Hatch identifier is not available](microsoft/vscode-python#22779 (comment)), we infer an environment is Hatch if we get it from the Hatch locator: microsoft/vscode-python#22779.
…icrosoft/vscode-python#23102) For microsoft/vscode-python#19153 Filter out any pipenv or poetry envs which do not belong to the current workspace.
- Updating walkthrough based on previous experiment - Updating based on microsoft/vscode-python#22664 Co-authored-by: Eleanor Boyd <[email protected]>
Add missing localization lock
Create env button should be `false` by default and the notification prompt should be enabled by default
…osoft/vscode-python#23099) - This has already been discussed and resolved for tests discovery in this [PR](microsoft/vscode-python#22454) - I have now run into the same issue for executing the test suite and have applied the same fix in this PR - Tested and working [Issue](microsoft/vscode-python#23098) for this current PR [Original Issue](microsoft/vscode-python#22453) [Original PR](microsoft/vscode-python#22454) Co-authored-by: Eleanor Boyd <[email protected]>
microsoft/vscode-python#23148) fixes microsoft/vscode-python#22999 reverts some changes made here: microsoft/vscode-python#22885
…-python#23160) remove these edits from the release so instead it will start in insiders then be released as a point release
other changes needed for the rename. Removed unintentional not in pytestadapter/test_discovery.py which seems to have been left there by accident.
wesm
force-pushed
the
vscode-python-v2024.4.0
branch
from
3d5a751 to
dd08d81
Compare
|
After talking with Pete, there are two strategies we can use to avoid pushing many commits to main:
I'll just do the merge strategy for now so that we can keep things moving forward, but if we want to do the squash strategy next time, let me know and I will make sure that the tools are organized and documented |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some notes:
The net deletion is coming from src/test/pythonFiles/formatting being deleted upstream. It seems like this was intentional but haven't found the discussion yet about it. (it is indeed gone in main https://github.com/microsoft/vscode-python/tree/main/src/test/python_files)