Fix notebook error formatting #2695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't modify tracebacks in notebook mode. The notebook frontend assumes the format of tracebacks and adds links to them. If we modify the traceback, the frontend's formatting breaks. Also minor improvements to Positron notebook UI error styling.
seeM
force-pushed
the
fix-notebook-errors
branch
from
c5dd79d to
0e95aa4
Compare
|
Merging this so long, but happy to make address any issues in follow-up PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent
Address #2607.
Approach
Plumb the new session mode arg through to the shell and kernel, then use it to determine whether we should format tracebacks.
There's some tension between VSCode and Positron notebook UIs here. VSCode notebooks do error formatting in the notebook-renderers extension, whereas Positron notebooks expect the runtime to do formatting via ANSI/OSC8 escape codes. We may need a way to configure the runtime to still do error formatting for Positron notebooks but not VSCode notebooks, but since we aren't enabling Positron notebooks yet I think this is okay to merge.
QA Notes
See the issue for a repro.