Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add table display name to Data Explorer get_state RPC, show variable name in editor tab label #2775

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

wesm
Copy link
Contributor

@wesm wesm commented Apr 15, 2024

This adds simple plumbing to show the variable name in the editor table opening a data explorer

image

This isn't supported yet in R, but I checked that this change does not break with the current Ark release.

Addresses #2568 for Python

@wesm
Copy link
Contributor Author

wesm commented Apr 15, 2024

I'm going to merge this to try to get some of the protocol changes settled for the next round of R runtime changes. There may be a cleaner way to change the tab label, but the changes I made were small and inoffensive, so I think it's unlikely they will cause any immediate issues, but we can improve things in a subsequent PR.

@wesm wesm merged commit 108e917 into main Apr 15, 2024
24 checks passed
@wesm wesm deleted the feature/de-editor-title branch April 15, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant