Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable project wizard in release builds #3346

Merged
merged 11 commits into from
Jun 4, 2024

Conversation

sharon-wang
Copy link
Member

@sharon-wang sharon-wang commented May 31, 2024

Intent

Approach

  • remove the feature flag code fences, so the project wizard is shown by default in both dev builds and release builds
  • repurpose the existing configuration setting to instead feature flag WIP project wizard features
  • unrelated fix to hide interpreter dropdown feedback when interpreters are still loading
  • since the project wizard will be available in release builds, disable the Create button for a new python-based project with Conda, although the dropdown will show when the configuration setting is enabled
  • feature flag Conda and renv::init UI, as these are not yet implemented

QA Notes

Local Release Build

For some reason, the updated config setting doesn't always get picked up into the release build. The following steps seem to be necessary:

  • ensure you've closed any other instances of Positron
  • delete the out* directories (maybe you don't need to delete all of them, but just in case!)
    image
  • rebuild the release yarn gulp vscode
  • your build has the expected changes if you see the setting on the right
    Untitled

@sharon-wang sharon-wang requested a review from softwarenerd June 3, 2024 13:22
Copy link
Member Author

@sharon-wang sharon-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ready for review, but I'm leaving it as a Draft PR while the project wizard issues are being verified, so it doesn't get accidentally merged in the meantime.

@sharon-wang sharon-wang marked this pull request as ready for review June 3, 2024 15:56
@sharon-wang sharon-wang requested a review from timtmok June 3, 2024 17:30
@sharon-wang sharon-wang force-pushed the feature/project-wizard-enable-by-default branch from 9b2f060 to 208c7c6 Compare June 4, 2024 14:12
@petetronic
Copy link
Collaborator

Rebuilt positron for Mac ARM64 locally and confirmed that New Project options were available and the new advanced setting gating work in progress was present and disabled by default. Enabling this exposed the WIP features.

Copy link
Contributor

@timtmok timtmok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sharon-wang sharon-wang merged commit 8e17a44 into main Jun 4, 2024
1 check passed
@sharon-wang sharon-wang deleted the feature/project-wizard-enable-by-default branch June 4, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants