-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable project wizard in release builds #3346
Conversation
The project wizard WIP functionality will depend entirely on the setting being enabled, regardless of whether the IDE is a dev build or a release build.
Creating the project with a conda env is not yet supported. Undefined behavior will occur if the user tries to create a project with conda as the env provider.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is ready for review, but I'm leaving it as a Draft PR while the project wizard issues are being verified, so it doesn't get accidentally merged in the meantime.
src/vs/workbench/browser/positronNewProjectWizard/components/steps/pythonEnvironmentStep.tsx
Show resolved
Hide resolved
src/vs/workbench/browser/positronNewProjectWizard/components/steps/pythonEnvironmentStep.tsx
Show resolved
Hide resolved
src/vs/workbench/contrib/welcomeGettingStarted/browser/positronWelcomePageLeft.tsx
Show resolved
Hide resolved
9b2f060
to
208c7c6
Compare
Rebuilt positron for Mac ARM64 locally and confirmed that New Project options were available and the new advanced setting gating work in progress was present and disabled by default. Enabling this exposed the WIP features. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Intent
Approach
QA Notes
positron.work-In-ProgressProjectWizardFeatures
(looking up "wizard" is probably sufficient)renv::init
for R projects: Project Wizard: createrenv::init
command #3127conda
as a python environment provider: Project Wizard: Python project environment step - Conda #2839Local Release Build
For some reason, the updated config setting doesn't always get picked up into the release build. The following steps seem to be necessary:
out*
directories (maybe you don't need to delete all of them, but just in case!)yarn gulp vscode