Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Urls always opening in Plots view #4966

Merged
merged 3 commits into from
Oct 10, 2024
Merged

Urls always opening in Plots view #4966

merged 3 commits into from
Oct 10, 2024

Conversation

timtmok
Copy link
Contributor

@timtmok timtmok commented Oct 9, 2024

Address #4909

The first PR didn't actually check the call stack. This checks the call stack properly for Plotly being called.

QA Notes

This was initially discovered because the Plotly module is loaded because of other tests that use it. So, Plotly only needs to be imported to reproduce the bug.

@timtmok timtmok requested a review from seeM October 9, 2024 18:36
Copy link
Contributor

@seeM seeM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Confirmed locally that plotly plots get sent to the plots pane and running a vetiver app previews it in the viewer pane.

@timtmok timtmok merged commit 52d5be2 into main Oct 10, 2024
23 checks passed
@timtmok timtmok deleted the bugfix/plotly-viewer-stack branch October 10, 2024 13:35
@github-actions github-actions bot locked and limited conversation to collaborators Oct 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants