-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the Jupyter supervisor the default in non-desktop Positron configurations #5215
Conversation
Co-authored-by: sharon <[email protected]> Signed-off-by: Jonathan <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I can confirm that Kallichore was enabled by default, with its Terminal hidden in Positron Server Web. After enabling the option to show the Kallichore Terminal and restarting Server Web, the Terminal became visible. I played around with starting, stopping and restarting Python and R Consoles and all was well 👍
On Desktop, Kallichore was not enabled by default as expected. Toggling the settings to enable Kallichore and show its Terminal also worked as expected.
I haven't had a chance to test this on Workbench yet though.
This change makes Kallichore the default in non-desktop configurations of Positron, such as on Posit Workbench. In addition to the configuration change, it includes a number of other changes that improve the stability of the supervisor integration in order to bring it up to the quality needed.
In particular:
setConsoleWidth
errors in the logs.Addresses #4941.
QA Notes
If logging issues, it's helpful to include the Kallichore logs, so run with the "Show Terminal" setting (added in this PR) turned on.