Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the Jupyter supervisor the default in non-desktop Positron configurations #5215

Merged
merged 24 commits into from
Oct 30, 2024

Conversation

jmcphers
Copy link
Collaborator

This change makes Kallichore the default in non-desktop configurations of Positron, such as on Posit Workbench. In addition to the configuration change, it includes a number of other changes that improve the stability of the supervisor integration in order to bring it up to the quality needed.

In particular:

  • The supervisor's behavior around session starting has changed; the RPC that starts sessions now doesn't return until the session has fully started and returned kernel information. We pick up this kernel info in Positron rather than making our own RPC for kernel info (when starting for the first time).
  • We now hold any attempts to make UI Comm requests until the UI Comm has opened. This eliminates a lot of setConsoleWidth errors in the logs.
  • The Kallichore terminal is now hidden by default.
  • The R and Python extensions no longer have a hard dependency on the Jupyter Adapter extension. This allows them to work even when the Jupyter Adapter is unbootable (such as on REHL 9 or other systems where there are glibc issues with ZeroMQ)

Addresses #4941.

QA Notes

If logging issues, it's helpful to include the Kallichore logs, so run with the "Show Terminal" setting (added in this PR) turned on.

@jmcphers jmcphers requested a review from sharon-wang October 30, 2024 16:18
Copy link
Member

@sharon-wang sharon-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I can confirm that Kallichore was enabled by default, with its Terminal hidden in Positron Server Web. After enabling the option to show the Kallichore Terminal and restarting Server Web, the Terminal became visible. I played around with starting, stopping and restarting Python and R Consoles and all was well 👍

On Desktop, Kallichore was not enabled by default as expected. Toggling the settings to enable Kallichore and show its Terminal also worked as expected.

I haven't had a chance to test this on Workbench yet though.

@jmcphers jmcphers merged commit d6e9e79 into main Oct 30, 2024
27 of 28 checks passed
@jmcphers jmcphers deleted the feature/kallichore-default branch October 30, 2024 22:44
@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants