-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve runtime session service stability #5380
Merged
Merged
Changes from all commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
3d9d2e3
throw an error when starting a notebook session without a notebook uri
seeM 3a354a3
throw an error when starting a runtime for a notebook while another r…
seeM d58c28c
throw an error when starting a runtime for a notebook while another r…
seeM 19368eb
update restoreRuntimeSession: add validation; coalesce concurrent req…
seeM bb7df67
fix leaked disposable
seeM 974aa05
log uncaught exception
seeM a7197bd
update test session manager for tests
seeM 5f1a33f
checkpoint tests
seeM 5883cd8
checkpoint 2 tests
seeM 7069706
refactor to generate tests
seeM ad4a962
add selectRuntime to start tests
seeM 4187cf5
log uncaught promise rejection
seeM fe6a5f9
all current tests passing
seeM 34a37c3
add auto start and more select tests;
seeM fe5a76e
change error message when selecting a non-existing runtime
seeM 6487dea
throw when starting a notebook in an untrusted workspace
seeM 987af00
coalesce concurrent auto start requests; validate before auto start
seeM d6eb11c
finalize auto start tests
seeM fa91bf6
fix typo
seeM 79cad9e
add restart tests
seeM ed52e44
fix restarting notebooks
seeM 6044bda
test encountering createSession/restoreSession error; catch uncaught …
seeM 1b54978
refine test session shutdown & restart behavior; fix related tests; s…
seeM b1eb0c4
skip failing test for now
seeM 0a89f1e
fix leaked disposable
seeM d15995b
wip fixing restart queueing issue
seeM 8ae2a4a
make console session for language/runtime checks explicit
seeM 0558d3d
return the correct session for selectRuntime test helper
seeM 84c37aa
make activeSessions check explicit
seeM b67b6f9
test starting after an error was encountered previously
seeM 4e7efaf
test actual objects since there could be multiple sessions with the s…
seeM 9acb4b0
remove unneeded roundtrip
seeM 801d0d7
we can actually use `getConsoleSessionForRuntime` after the fix
seeM 275b611
fix: return the latest matching console in `getConsoleSessionForRuntime`
seeM c9077df
fix: notebook sessions not being set/cleared from starting starting s…
seeM 7b84fda
re-add restore fires onWillStartSession test
seeM f9bee54
fix import across environment types
seeM 688322d
fix leaked disposable
seeM 2d5092a
stop notebook runtime error messages from showing up in the console
seeM 586b7e1
sort by createdTimestamp instead of insert order
seeM 0259c3d
fix multiple sessions having the same `createdTimestamp`
seeM 0e3cf4f
fix restart while ready not clearing the starting maps
seeM 065e6e7
add `onDidEndSession` disposable to the session's disposables
seeM 811cc2f
fix uncaught error
seeM 25cea7f
dont use assert.strict since it doesnt seem to work in the browser en…
seeM File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -20,12 +20,11 @@ import { ViewContainer, IViewContainersRegistry, ViewContainerLocation, Extensio | |
import { registerAction2 } from 'vs/platform/actions/common/actions'; | ||
import { PositronOpenUrlInViewerAction } from 'vs/workbench/contrib/positronPreview/browser/positronPreviewActions'; | ||
import { IConfigurationRegistry, Extensions as ConfigurationExtensions, ConfigurationScope, } from 'vs/platform/configuration/common/configurationRegistry'; | ||
import { POSITRON_PREVIEW_PLOTS_IN_VIEWER } from 'vs/workbench/services/languageRuntime/common/languageRuntimeUiClient'; | ||
|
||
// The Positron preview view icon. | ||
const positronPreviewViewIcon = registerIcon('positron-preview-view-icon', Codicon.positronPreviewView, nls.localize('positronPreviewViewIcon', 'View icon of the Positron preview view.')); | ||
|
||
export const POSITRON_PREVIEW_PLOTS_IN_VIEWER = 'positron.viewer.interactivePlotsInViewer'; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Needed to move this from |
||
|
||
// Register the Positron preview container. | ||
const VIEW_CONTAINER: ViewContainer = Registry.as<IViewContainersRegistry>(ViewContainerExtensions.ViewContainersRegistry).registerViewContainer({ | ||
id: POSITRON_PREVIEW_VIEW_ID, | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
355 changes: 266 additions & 89 deletions
355
src/vs/workbench/services/runtimeSession/common/runtimeSession.ts
Large diffs are not rendered by default.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cleaning up some log noise.