Fix F1 for help in Python #5405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seeM
commented
Nov 18, 2024
| @@ -87,7 +87,7 @@ class PositronComm: | |||
|
|
|||
| def __init__(self, comm: comm.base_comm.BaseComm) -> None: | |||
| self.comm = comm | |||
| self.send_lock = threading.Lock() | |||
| self.send_lock = threading.RLock() | |||
There was a problem hiding this comment.
This is the actual fix. The rest is to update the help tests to use the PositronComm instead of the base comm to be able to catch bugs like this one.
isabelizimm
previously approved these changes
Nov 18, 2024
|
Ah, looks like |
seeM
force-pushed
the
5290-fix-f1-for-python
branch
from
f699e89 to
31c0410
Compare
wesm
pushed a commit
that referenced
this pull request
Nov 19, 2024
from errors noted in #5405 ; macos-12 has been deprecated actions/runner-images#10721
|
Thanks for getting this merged @wesm & @isabelizimm! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #5290. The issue was a deadlock when handling the
show_help_topicrequest when it tries to send theshow_helpevent, since bothPositronComm.on_msgandsend_eventacquire the same lock.@wesm IIUC the purpose was to allow delaying a
send_eventcall in a separate thread until after the message handler completes. I think both cases are solved by using a reentrant lock (RLock()).QA Notes
F1 should work again in Python.