Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e-test: browser in parallel & enable Currents #5442

Merged
merged 35 commits into from
Nov 27, 2024
Merged

e2e-test: browser in parallel & enable Currents #5442

merged 35 commits into from
Nov 27, 2024

Conversation

midleman
Copy link
Contributor

@midleman midleman commented Nov 21, 2024

Summary

This PR enables the Currents dashboard integration to evaluate the tool’s usefulness.

Additionally, the browser is now configured to run on multiple ports, allowing browser tests to execute in parallel.

I also consolidated matrix runs into a single machine and enabled multiple threads/workers. This adjustment seems to align better with the current setup and is likely more cost-efficient.

QA Notes

I performed numerous test runs to monitor the potential for increased flakiness with parallel workers. The results are promising overall. While I observed some minor flakiness, these issues appear manageable and can be addressed with further adjustments.

@midleman midleman marked this pull request as ready for review November 27, 2024 16:09
@midleman midleman changed the title add currents e2e-test: browser in parallel & enable Currents Nov 27, 2024
testlabauto
testlabauto previously approved these changes Nov 27, 2024
Copy link
Contributor

@testlabauto testlabauto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@testlabauto testlabauto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@midleman midleman merged commit c5ce275 into main Nov 27, 2024
11 checks passed
@midleman midleman deleted the mi/currents-ii branch November 27, 2024 19:52
@github-actions github-actions bot locked and limited conversation to collaborators Nov 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants