Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jonv-more-windows-tests #5719

Merged
merged 11 commits into from
Dec 13, 2024
Merged

Jonv-more-windows-tests #5719

merged 11 commits into from
Dec 13, 2024

Conversation

jonvanausdeln
Copy link
Contributor

@jonvanausdeln jonvanausdeln commented Dec 12, 2024 •
edited
Loading

Intent

Turns on more test in windows CI

QA Notes

Passes in CI

@jonvanausdeln jonvanausdeln self-assigned this Dec 12, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 12, 2024 •
edited
Loading

E2E Tests 🚀  ?
This PR will run tests tagged with: @critical

@jonvanausdeln jonvanausdeln marked this pull request as ready for review December 12, 2024 23:55
midleman
midleman approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@midleman midleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you run just 1x or multiples? Just curious. :shipit:

testlabauto
testlabauto approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@testlabauto testlabauto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Some long timeouts, but I think those cases have 2 mins to complete.

@jonvanausdeln
Copy link
Contributor Author

Did you run just 1x or multiples? Just curious. :shipit:

1x

@jonvanausdeln
Copy link
Contributor Author

LGTM! Some long timeouts, but I think those cases have 2 mins to complete.

Yeah... the venv starting takes long time now.. it even times out occasionally on Linux.

@jonvanausdeln jonvanausdeln merged commit cff3f12 into main Dec 13, 2024
7 checks passed
@jonvanausdeln jonvanausdeln deleted the jonv-more-windows-tests branch December 13, 2024 00:01
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@testlabauto testlabauto testlabauto approved these changes

@midleman midleman midleman approved these changes

Assignees

@jonvanausdeln jonvanausdeln

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonvanausdeln @midleman @testlabauto