Package 'positron-proxy' and 'positron-duckdb' dependencies #5756
+97
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
E2E Tests 🚀 ? |
|
Tested a locally built release on Mac and it addressed both of the issues mentioned, though I'm trying to repeat this on Windows and am running into an issue completing building the release. |
petetronic
approved these changes
Dec 17, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes the Positron Proxy and Positron-DuckDB (CSV/TSV/Parquet viewer) extension bundling in release builds. An upstream change caused dependencies of built-in extensions to be ignored; this is mostly fine but a couple of our built-in extensions have third-party dependencies that need to be processed.
The fix is to use the NPM dependency detection strategy on these specific extensions. We can't just use this strategy on all extensions since it does not work on extensions that have dependencies that are externally supplied (which is the case for several Microsoft and Positron extensions).
Additional fixes:
help.htmlfile in the Help pane in release builds, and makes the error visible if we can't.EMFILE).Addresses #5742
Addresses #5743
e2e: @:data-explorer
QA Notes
This problem only reproduces in release builds.