Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Python interpreter not found error #5793

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

seeM
Copy link
Contributor

@seeM seeM commented Dec 18, 2024

Attempts to address #5730. My hunch is that getInterpreters() doesn't wait for the Python extension to complete its discovery process, so it's possible to get there before our runtime's interpreter is discovered.

The whole point of restoring a workspace-affiliated runtime is to skip discovery. It looks like getInterpreterDetails() is a better fit, since (I think) it "resolves" an interpreter path to a PythonEnvironment independent of discovery.

QA Notes

E2E tests C609619 and C609617 should pass in CI:

Python and Reticulate runtimes should continue to function as expected.

Copy link

github-actions bot commented Dec 18, 2024

E2E Tests 🚀  ?
This PR will run tests tagged with: @critical

@seeM seeM requested review from jmcphers and juliasilge December 18, 2024 18:43
Copy link
Collaborator

@jmcphers jmcphers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. I ran through the steps in #5730 and found that the new venv successfully started up when reopening the project.

Copy link
Contributor

@dfalbel dfalbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Locally tested the reticulate functionality and everything seems to work correctly.

Copy link
Contributor

@juliasilge juliasilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much! 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants