Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark theme #45

Merged
merged 59 commits into from
May 9, 2024
Merged

Dark theme #45

merged 59 commits into from
May 9, 2024

Conversation

AshleyHenry15
Copy link
Contributor

@AshleyHenry15 AshleyHenry15 commented Apr 22, 2024

This PR adds a dark theme and resolves other theme-related issues:

Resolves #57
Resolves #7

Known issues:
#56
#59
Flashing: quarto-dev/quarto-cli#1325

Outstanding items tracking:

  • Nav bar drop-down menu: update hover color

Before we merge:

  • Update changelog
  • Clean up CSS (make sure that I don't have duplicates, that the style sheets follow the same order/org, etc.)
  • Maybe clean up examples in files?

Link to view docs:
https://ashley.quarto.pub/theme-testing/

… the brackets - the main theme wasn't applied
@AshleyHenry15 AshleyHenry15 requested review from aronatkins, edavidaja and m-- and removed request for aronatkins May 9, 2024 12:51
@AshleyHenry15 AshleyHenry15 changed the title DRAFT: Dark theme blue option Dark theme blue option May 9, 2024
@AshleyHenry15 AshleyHenry15 changed the title Dark theme blue option Dark theme May 9, 2024
These are weird - they don't play nicely with the bootstrap icons as far as sizing and also alignment. Should revisit at some point. Hoping that Quarto product adjustments may help with this.
Tried to align them both so they would be in the same order, removed duplication, standardized "labels", etc.
Copy link
Contributor

@edavidaja edavidaja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more flash than a website in 1999

Copy link
Contributor

@m-- m-- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there are some commented-out lines in the dark mode .scss file, not sure if those are still needed or not? Also, there's some inconsistent whitespace formatting in that file, not sure if you want to fix that (either as part of this, or at some point in the future), but i thought i'd mention it. Hooray dark mode! 😎 🎉

_extensions/posit-docs/theme-dark.scss Outdated Show resolved Hide resolved
_extensions/posit-docs/theme-dark.scss Outdated Show resolved Hide resolved
_extensions/posit-docs/theme-dark.scss Outdated Show resolved Hide resolved
@aronatkins
Copy link
Contributor

Visual feedback for dark-mode. I was testing using Safari. None of this is must-fix; only recording my initial reactions. Also keep in mind that I am not the target audience for this theme.

Code

The font/color choices for code blocks and inline code make them feel more prominent than the surrounding text. Here's one small example, but it also applies to other occurrences.

image

This felt especially pronounced with the "Output or filenames" code chunk; it drew my eye over everything else on the page.

Table headers

Table headers feel more visually prominent in dark mode than in light mode. This may be because they use a brighter color than the surrounding text. The fact that they are bold makes them more of a visual draw than the accompanying section header.

image

Table row highlighting

Table row highlighting feels much more subtle in dark mode than in light mode.

image

Code-nested tabset

The nested tabset beneath the "code" pill is doing some strange things.

First, there appears to be a tiny underline lingering on the left, perhaps because the bubble around RHEL is too large?

image

Second, on mouseover, the whole set of headings shifts around. This screen recording shows the effect:

tab-hop

Callout icons

The callout icons probably need to be a lighter color.

image

changelog.md Outdated Show resolved Hide resolved
index-2.qmd Outdated Show resolved Hide resolved
@AshleyHenry15
Copy link
Contributor Author

@aronatkins - The nesting of the pills and tabs gets weird. I am assuming that it is due to the nesting of the different styles. I think that I will remove the example from the file for now until I can dive in and figure out if there is a way to make that work nicely.

  • Table header color: I had changed it to white for accessibility but I just tested and it passes with the gray. So, I have removed the white coloring to the th class, and it should be fixed now.
  • Table rows: Yeah, we went back and forth on the colors for this a lot. I used GitHub tables as an example but the blue complicates things. This will likely be something that I bring up with Veronica for some guidance at some point.

@AshleyHenry15 AshleyHenry15 merged commit 9b7b42b into main May 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Callout colors dark mode?!
4 participants