-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dark theme #45
Dark theme #45
Conversation
…py button color to a darker posit blue
… the brackets - the main theme wasn't applied
…ors to the color-variables list
These are weird - they don't play nicely with the bootstrap icons as far as sizing and also alignment. Should revisit at some point. Hoping that Quarto product adjustments may help with this.
Tried to align them both so they would be in the same order, removed duplication, standardized "labels", etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
more flash than a website in 1999
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like there are some commented-out lines in the dark mode .scss
file, not sure if those are still needed or not? Also, there's some inconsistent whitespace formatting in that file, not sure if you want to fix that (either as part of this, or at some point in the future), but i thought i'd mention it. Hooray dark mode! 😎 🎉
@aronatkins - The nesting of the pills and tabs gets weird. I am assuming that it is due to the nesting of the different styles. I think that I will remove the example from the file for now until I can dive in and figure out if there is a way to make that work nicely.
|
This PR adds a dark theme and resolves other theme-related issues:
Resolves #57
Resolves #7
Known issues:
#56
#59
Flashing: quarto-dev/quarto-cli#1325
Outstanding items tracking:
Before we merge:
Link to view docs:
https://ashley.quarto.pub/theme-testing/