Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

svg as base64 url data #60

Merged
merged 3 commits into from
May 10, 2024
Merged

svg as base64 url data #60

merged 3 commits into from
May 10, 2024

Conversation

aronatkins
Copy link
Contributor

@aronatkins aronatkins commented May 10, 2024 •
edited
Loading

Remove extension paths to images and replace with base64 image data.

@aronatkins aronatkins requested a review from AshleyHenry15 May 10, 2024 15:40
AshleyHenry15
AshleyHenry15 approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@AshleyHenry15 AshleyHenry15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since I can't inspect nor confirm that the regular icons and DM icons were converted - I previewed and they look correct but again - I can't inspect to confirm

@aronatkins aronatkins requested review from AshleyHenry15 and m-- May 10, 2024 16:04
@aronatkins aronatkins merged commit 846264b into main May 10, 2024
1 check passed
@aronatkins aronatkins deleted the aron-base64-svg branch May 10, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-- m-- m-- approved these changes

@AshleyHenry15 AshleyHenry15 Awaiting requested review from AshleyHenry15

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aronatkins @m-- @AshleyHenry15