frontend validation

posit-dev · Sep 25, 2023 · 72bac84 · 72bac84
1 parent 37c5f01
commit 72bac84
Show file tree

Hide file tree

Showing 5 changed files with 38 additions and 34 deletions.
diff --git a/extensions/jupyterlab/connect_jupyterlab/.vscode/settings.json b/extensions/jupyterlab/connect_jupyterlab/.vscode/settings.json
@@ -1,10 +1,7 @@
 {
-    "[python]": {
-        "editor.defaultFormatter": "ms-python.black-formatter"
-    },
-    "python.formatting.provider": "none",
-    "black-formatter.args": [
-        "--line-length",
-        "99"
-    ]
-}
+  "[python]": {
+    "editor.defaultFormatter": "ms-python.black-formatter"
+  },
+  "python.formatting.provider": "none",
+  "black-formatter.args": ["--line-length", "99"]
+}
diff --git a/extensions/jupyterlab/connect_jupyterlab/justfile b/extensions/jupyterlab/connect_jupyterlab/justfile
@@ -8,3 +8,8 @@ validate-python:
     black ./connect_jupyterlab --line-length {{ max_line_length }}
     flake8 ./connect_jupyterlab --max-line-length {{ max_line_length }}
     mypy ./connect_jupyterlab
+
+validate-js:
+    npm run lint:check
+
+validate: validate-js validate-python
diff --git a/extensions/jupyterlab/connect_jupyterlab/schema/plugin.json b/extensions/jupyterlab/connect_jupyterlab/schema/plugin.json
@@ -1,16 +1,16 @@
 {
-    "jupyter.lab.toolbars": {
-      "Notebook": [
-        {
-          "name": "posit-publish",
-          "command": "posit:publish",
-          "args": { "origin": "toolbar" }
-        }
-      ]
-    },
-    "title": "@rstudio/posit-publish",
-    "description": "@rstudio/posit-publish settings.",
-    "type": "object",
-    "properties": {},
-    "additionalProperties": false
-  }
+  "jupyter.lab.toolbars": {
+    "Notebook": [
+      {
+        "name": "posit-publish",
+        "command": "posit:publish",
+        "args": { "origin": "toolbar" }
+      }
+    ]
+  },
+  "title": "@rstudio/posit-publish",
+  "description": "@rstudio/posit-publish settings.",
+  "type": "object",
+  "properties": {},
+  "additionalProperties": false
+}
diff --git a/extensions/jupyterlab/connect_jupyterlab/style/base.css b/extensions/jupyterlab/connect_jupyterlab/style/base.css
@@ -5,16 +5,16 @@
 */
 
 .rsc-icon {
-    font-size: 18px;
-    /* make the existing icon transparent so it is not visible */
-    color: transparent;
-    /* add a background-image. size 40 x 36 */
-    background-image: url(data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAACgAAAAkCAYAAAD7PHgWAAACUUlEQVR42mNgGAWjYBSMVDDzPyvD9GfBDDOez2OY+fwikH4HxH8Ypj9/BRQ/CmR3MUx/ajgwjpv+PIFhxosnQEf8JwLvpZ9D59/nAFq4kkiHIePfQA/l09Zxq66wMcx4tosMxyHhl/q0jNYeHBbfAMo1MEx74QekHRhmvXABpsl4oPh0IP6AonbaSz0aOQ6YhmY8/4vmsG/AzJDOUP+fCae+ya+lgOqOAx38lGHmiwrahd6M55vQHPeTYdZz+wEqPp6HouDpz2LBxQeyA2c+L0XRAwrFGc/sgBkhl2H6iyRgdCvRMrQIJfabQAexwNXPeqIGFDuHpuYvMD1OA2cs+jvwWRpc7bznokCxx3jUz6O3A38wTHrLh1D7rI2A+n/UL1rwWTjz+UZUtS/OEwxx9PRKMZj2UBAnBtUkqBnqNhFpthGufvYLRSD/LhA/g9bdMPwaKn6YyqH9Yj1BB05/HoYUO+UE1D+ksgNfuhKw8BFD32NOJAdeoa8DIdFcj8Oyd8DawxxRGz1zJyI5PKRR4f7MDZyBIOnoCpA9mWHqU1nUhgZGWXkYGuUwXEfb6hBvUng2ASO0QI0KmoA5j4XAITTj+VpwriTURJv+bCKWqDxGy9CYg2TRB6AD2oEOdmSY+VoSWAwJQDzw1AgcXTOe38fiuO/A+lqHlg6kpNH6D9xdoHF/xAxo0RsyHAfsUD1LpU+in/1EBhitayB1LVGOuwqMdhv6505QEx6SCe5gcdRriCeeBTGs+s88CPrJ7/gZpj1VB+PZL8VHBw5GwSigEwAAO8Vb1WEAypEAAAAASUVORK5CYII=);
-    background-size: contain;
+  font-size: 18px;
+  /* make the existing icon transparent so it is not visible */
+  color: transparent;
+  /* add a background-image. size 40 x 36 */
+  background-image: url(data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAACgAAAAkCAYAAAD7PHgWAAACUUlEQVR42mNgGAWjYBSMVDDzPyvD9GfBDDOez2OY+fwikH4HxH8Ypj9/BRQ/CmR3MUx/ajgwjpv+PIFhxosnQEf8JwLvpZ9D59/nAFq4kkiHIePfQA/l09Zxq66wMcx4tosMxyHhl/q0jNYeHBbfAMo1MEx74QekHRhmvXABpsl4oPh0IP6AonbaSz0aOQ6YhmY8/4vmsG/AzJDOUP+fCae+ya+lgOqOAx38lGHmiwrahd6M55vQHPeTYdZz+wEqPp6HouDpz2LBxQeyA2c+L0XRAwrFGc/sgBkhl2H6iyRgdCvRMrQIJfabQAexwNXPeqIGFDuHpuYvMD1OA2cs+jvwWRpc7bznokCxx3jUz6O3A38wTHrLh1D7rI2A+n/UL1rwWTjz+UZUtS/OEwxx9PRKMZj2UBAnBtUkqBnqNhFpthGufvYLRSD/LhA/g9bdMPwaKn6YyqH9Yj1BB05/HoYUO+UE1D+ksgNfuhKw8BFD32NOJAdeoa8DIdFcj8Oyd8DawxxRGz1zJyI5PKRR4f7MDZyBIOnoCpA9mWHqU1nUhgZGWXkYGuUwXEfb6hBvUng2ASO0QI0KmoA5j4XAITTj+VpwriTURJv+bCKWqDxGy9CYg2TRB6AD2oEOdmSY+VoSWAwJQDzw1AgcXTOe38fiuO/A+lqHlg6kpNH6D9xdoHF/xAxo0RsyHAfsUD1LpU+in/1EBhitayB1LVGOuwqMdhv6505QEx6SCe5gcdRriCeeBTGs+s88CPrJ7/gZpj1VB+PZL8VHBw5GwSigEwAAO8Vb1WEAypEAAAAASUVORK5CYII=);
+  background-size: contain;
 }
 
 .jp-posit-publishing-view {
-    width: 100%;
-    height: 100%;
-    border-width: 0px;
+  width: 100%;
+  height: 100%;
+  border-width: 0px;
 }
diff --git a/extensions/jupyterlab/connect_jupyterlab/ui-tests/tests/connect_jupyterlab.spec.ts b/extensions/jupyterlab/connect_jupyterlab/ui-tests/tests/connect_jupyterlab.spec.ts
@@ -16,6 +16,8 @@ test('should emit an activation console message', async ({ page }) => {
   await page.goto();
 
   expect(
-    logs.filter(s => s === 'JupyterLab extension connect_jupyterlab is activated!')
+    logs.filter(
+      s => s === 'JupyterLab extension connect_jupyterlab is activated!'
+    )
   ).toHaveLength(1);
 });