Skip to content

Commit

Permalink
Reverts change to use 'just ci' command. (#322)
Browse files Browse the repository at this point in the history
  • Loading branch information
tdstein authored Oct 27, 2023
1 parent 43873e6 commit bd21696
Show file tree
Hide file tree
Showing 12 changed files with 38 additions and 85 deletions.
3 changes: 2 additions & 1 deletion .github/workflows/agent.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,5 @@ jobs:
with:
fetch-depth: 0
- uses: ./.github/actions/setup
- run: just ci
- run: just lint
- run: just test
6 changes: 4 additions & 2 deletions .github/workflows/bats.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@ jobs:
name: executables
path: bin
- run: chmod -R +x ./bin
- run: just bats ci
- run: just bats install
- run: just bats test
docker:
strategy:
fail-fast: false
Expand All @@ -37,4 +38,5 @@ jobs:
name: executables
path: bin
- run: chmod -R +x ./bin
- run: just bats ci
- run: just bats install
- run: just bats test
3 changes: 2 additions & 1 deletion .github/workflows/cypress.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,4 +20,5 @@ jobs:
name: executables
path: bin
- run: chmod -R +x ./bin
- run: just cy ci
- run: just cy install
- run: just cy test
4 changes: 3 additions & 1 deletion .github/workflows/jupyterlab.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,6 @@ jobs:
with:
python-version: '3.11'
- uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1
- run: just jupyterlab ci
- run: just jupyterlab install
- run: just jupyterlab lint
- run: just jupyterlab test
8 changes: 6 additions & 2 deletions .github/workflows/positron.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,16 @@ jobs:
- uses: actions/setup-node@v3
with:
node-version: 18.x
- run: just positron ci
- run: just positron install
- run: just positron lint
- run: just positron test
docker:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
with:
fetch-depth: 0
- uses: ./.github/actions/setup
- run: just positron ci
- run: just positron install
- run: just positron lint
- run: just positron test
4 changes: 3 additions & 1 deletion .github/workflows/web.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,6 @@ jobs:
with:
fetch-depth: 0
- uses: ./.github/actions/setup
- run: just web ci
- run: just web install
- run: just web lint
- run: just web test
10 changes: 0 additions & 10 deletions extensions/jupyterlab/connect_jupyterlab/justfile
Original file line number Diff line number Diff line change
Expand Up @@ -10,16 +10,6 @@ _with_debug := if _debug == "true" {
""
}

# Executes continuous integration workflow (i.e., this is what GitHub Actions uses)
ci:
#!/usr/bin/env bash
set -eou pipefail
{{ _with_debug }}
just install
just lint
just test

default:
#!/usr/bin/env bash
set -eou pipefail
Expand Down
13 changes: 2 additions & 11 deletions extensions/positron/justfile
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,13 @@ _with_debug := if _debug == "true" {
""
}

# Executes continuous integration workflow (i.e., this is what GitHub Actions uses)
ci:
# Quick start
default:
#!/usr/bin/env bash
set -eou pipefail
{{ _with_debug }}
just install
just lint
just test

# Deletes ephemeral project files (i.e., cleans the project).
Expand All @@ -30,14 +29,6 @@ clean:
rm -rf node_modules

default:
#!/usr/bin/env bash
set -eou pipefail
{{ _with_debug }}
just install
just test


# Install dependencies
install:
Expand Down
30 changes: 10 additions & 20 deletions justfile
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,16 @@ _uid_args := if os_family() == "unix" {
""
}

# Quick start
default:
#!/usr/bin/env bash
set -eou pipefail
{{ _with_debug }}
just clean
just web
just build

# Executes command against every justfile where avaiable. WARNING your mileage may very.
all +args='default':
#!/usr/bin/env bash
Expand Down Expand Up @@ -71,16 +81,6 @@ build:
just _with_docker env MODE={{ _mode }} ./scripts/build.bash {{ _cmd }}

# Executes continuous integration workflow (i.e., this is what GitHub Actions uses)
ci:
#!/usr/bin/env bash
set -eou pipefail
{{ _with_debug }}
just install
just lint
just test

# Deletes ephemeral project files (i.e., cleans the project).
clean:
#!/usr/bin/env bash
Expand All @@ -105,16 +105,6 @@ cy *args:
just _with_docker just test/cy/{{ args }}

# Quick start
default:
#!/usr/bin/env bash
set -eou pipefail
{{ _with_debug }}
just clean
just web
just build

# Prints the executable path for this operating system. It may not exist yet (see `just build`).
executable-path:
#!/usr/bin/env bash
Expand Down
11 changes: 1 addition & 10 deletions test/bats/justfile
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,7 @@ _with_debug := if _debug == "true" {
""
}

# Executes continuous integration workflow (i.e., this is what GitHub Actions uses)
ci:
default:
#!/usr/bin/env bash
set -eou pipefail
{{ _with_debug }}
Expand All @@ -29,14 +28,6 @@ clean:
rm -rf node_modules

default:
#!/usr/bin/env bash
set -eou pipefail
{{ _with_debug }}
just clean
just install
just test

# Install dependencies
install:
Expand Down
13 changes: 1 addition & 12 deletions test/cy/justfile
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,12 @@ _with_debug := if _debug == "true" {
""
}

# Executes continuous integration workflow (i.e., this is what GitHub Actions uses)
ci:
default:
#!/usr/bin/env bash
set -eou pipefail
{{ _with_debug }}
just install
just lint
just test

# Deletes ephemeral project files (i.e., cleans the project).
Expand All @@ -30,15 +28,6 @@ clean:
rm -rf node_modules

default:
#!/usr/bin/env bash
set -eou pipefail
{{ _with_debug }}
just clean
just install
just test

fix:
#!/usr/bin/env bash
set -eou pipefail
Expand Down
18 changes: 4 additions & 14 deletions web/justfile
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,15 @@ _with_debug := if _debug == "true" {
""
}

# Executes continuous integration workflow (i.e., this is what GitHub Actions uses)
ci:
default:
#!/usr/bin/env bash
set -eou pipefail
{{ _with_debug }}
just clean
just install
just lint
just test
just build


# Compiles the static assests for the web client. Static assets are written to `./web/dist`.
build:
Expand All @@ -47,16 +47,6 @@ clean:
rm -rf dist
rm -rf node_modules

default:
#!/usr/bin/env bash
set -eou pipefail
{{ _with_debug }}
just clean
just install
just build


# Launch a local web server instance with hot-reloads.
dev:
#!/usr/bin/env bash
Expand Down

0 comments on commit bd21696

Please sign in to comment.