Stop auto importing accounts #1539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmarchetti
force-pushed
the
mm-no-auto-accounts
branch
from
9aeff2a to
0671a0d
Compare
mmarchetti
requested review from
dotNomad,
kgartland-rstudio,
sagerb and
tdstein
as code owners
sagerb
reviewed
May 10, 2024
sagerb
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intent
This PR turns off the auto-import of accounts from rsconnect and rsconnect-python. It's a draft for now because credential selection in the home view doesn't currently work when starting with no accounts.
Fixes #1535
Type of Change
Approach
Don't instantiate the rsconnect and rsconnect-python account providers. (Environment variables are still supported; see #1537)
Automated Tests
Existing test was updated.
Directions for Reviewers
Run the extension, see that those accounts are no longer present.